Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Plugin loader should prioritize new plugin format, when available #1846

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

vbabich
Copy link
Collaborator

@vbabich vbabich commented Feb 29, 2024

We should be able to use both new and legacy plugin format in the same module, and plugin loader should prioritize the new format.

@vbabich vbabich self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.03%. Comparing base (d91d833) to head (8b9a753).

Files Patch % Lines
packages/app-utils/src/plugins/PluginUtils.tsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
+ Coverage   46.00%   46.03%   +0.03%     
==========================================
  Files         635      635              
  Lines       37913    37931      +18     
  Branches     9553     9561       +8     
==========================================
+ Hits        17441    17461      +20     
+ Misses      20418    20416       -2     
  Partials       54       54              
Flag Coverage Δ
unit 46.03% <95.23%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vbabich vbabich added this to the February 2024 milestone Feb 29, 2024
@vbabich vbabich merged commit c6ef5b3 into deephaven:main Feb 29, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants