Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reopen closed tabs #1912

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 commented Apr 2, 2024

@wusteven815 wusteven815 self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 46.26%. Comparing base (b49b506) to head (b165ed6).
Report is 17 commits behind head on main.

Files Patch % Lines
packages/code-studio/src/main/AppMainContainer.tsx 0.00% 4 Missing ⚠️
packages/dashboard/src/PanelManager.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
+ Coverage   46.11%   46.26%   +0.14%     
==========================================
  Files         637      646       +9     
  Lines       38054    38259     +205     
  Branches     9620     9673      +53     
==========================================
+ Hits        17549    17699     +150     
- Misses      20452    20507      +55     
  Partials       53       53              
Flag Coverage Δ
unit 46.26% <20.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusteven815 wusteven815 marked this pull request as ready for review April 3, 2024 19:55
@@ -34,6 +41,11 @@ class PanelContextMenu extends PureComponent<
return [...(glContainer?.tab?.header?.tabs ?? [])];
}

handleReopenLast(): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should actually be re-opening the last panel in this stack, which means we also need to store which stack the panel was closed. I think pull that functionality into a separate PR, leave this PR just for the global re-open last panel action (which will show up as a keyboard shortcut under Settings).

We also will want a context menu on dashboards, but dashboards in community do not have context menu items (yet), could be another ticket as well.

This was after our discussion with @dsmmcken yesterday.

@wusteven815 wusteven815 linked an issue Apr 5, 2024 that may be closed by this pull request
@wusteven815 wusteven815 requested a review from mofojed April 5, 2024 16:52
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@wusteven815 wusteven815 merged commit c2e8714 into deephaven:main Apr 11, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@wusteven815 wusteven815 deleted the reopen-close-tab branch April 11, 2024 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow re-opening a closed tab panel
2 participants