-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reopen closed tabs #1912
feat: reopen closed tabs #1912
Conversation
wusteven815
commented
Apr 2, 2024
•
edited
Loading
edited
- Add Allow re-opening a closed tab panel #1785
- Add keyboard shortcut (Alt+Shift+A) to reopen last closed tab
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
==========================================
+ Coverage 46.11% 46.26% +0.14%
==========================================
Files 637 646 +9
Lines 38054 38259 +205
Branches 9620 9673 +53
==========================================
+ Hits 17549 17699 +150
- Misses 20452 20507 +55
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -34,6 +41,11 @@ class PanelContextMenu extends PureComponent< | |||
return [...(glContainer?.tab?.header?.tabs ?? [])]; | |||
} | |||
|
|||
handleReopenLast(): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should actually be re-opening the last panel in this stack, which means we also need to store which stack the panel was closed. I think pull that functionality into a separate PR, leave this PR just for the global re-open last panel action (which will show up as a keyboard shortcut under Settings).
We also will want a context menu on dashboards, but dashboards in community do not have context menu items (yet), could be another ticket as well.
This was after our discussion with @dsmmcken yesterday.
b1da3d3
to
b165ed6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.