-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DH-16865: Partitioned table with no data displays a spinner indefinitely #1904
Comments
Test it works if the table is ticking and a partition is added at least. This will load for around 20s until the first row ticks in from deephaven import time_table
t2 = time_table("PT20S").update("X=ii").where("X>0").partition_by("X") |
https://github.com/deephaven/web-client-ui/blob/main/packages/iris-grid/src/IrisGrid.tsx#L2042 |
We can show the empty table until the first key ticks in, in which case then we want to select that first key. |
Noticed the same behavior on a query that includes a where clause. However, the filter column used in where clause is not the partition column, behavior is the same in Legacy and Core+. Adding empty where() to the end of the query works. Adding the comment just to capture another use case. |
Verified that my changes do not fix this issue, can still see the spinner. Attempted to tested changes proposed in #1953 , but running into a lot of errors (I would assume that surrounding code has changed quite a bit in the interim). Looking at how we can combine both solutions here. |
## Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.86.0 ### Features * Add option to disable WebGL rendering ([#2134](deephaven/web-client-ui#2134)) ([011eb33](deephaven/web-client-ui@011eb33)) * Core plugins refactor, XComponent framework ([#2150](deephaven/web-client-ui#2150)) ([2571fad](deephaven/web-client-ui@2571fad)) * IrisGridTheme iconSize ([#2123](deephaven/web-client-ui#2123)) ([58ee88d](deephaven/web-client-ui@58ee88d)), closes [#885](deephaven/web-client-ui#885) * Partitioned Table UI Enhancements ([#2110](deephaven/web-client-ui#2110)) ([de5ce40](deephaven/web-client-ui@de5ce40)), closes [#2079](deephaven/web-client-ui#2079) [#2066](deephaven/web-client-ui#2066) [#2103](deephaven/web-client-ui#2103) [#2104](deephaven/web-client-ui#2104) [#2105](deephaven/web-client-ui#2105) [#2106](deephaven/web-client-ui#2106) [#2107](deephaven/web-client-ui#2107) [#2108](deephaven/web-client-ui#2108) [#2109](deephaven/web-client-ui#2109) [#2049](deephaven/web-client-ui#2049) [#2120](deephaven/web-client-ui#2120) [#1904](deephaven/web-client-ui#1904) ### Bug Fixes * error when edited cell is out of grid viewport ([#2148](deephaven/web-client-ui#2148)) ([3fccd43](deephaven/web-client-ui@3fccd43)), closes [#2087](deephaven/web-client-ui#2087) ## Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.85.2 ### Bug Fixes * Fix missing scrim background on LoadingOverlay ([#2098](deephaven/web-client-ui#2098)) ([c9ed895](deephaven/web-client-ui@c9ed895)) ## Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.85.1 ## [0.85.1](deephaven/web-client-ui@v0.85.0...v0.85.1) (2024-07-08) ### Bug Fixes * re-export remaining types needed by dh ui from @react-types/shared ([#2132](deephaven/web-client-ui#2132)) ([2119a61](deephaven/web-client-ui@2119a61)) ## Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.85.0 ### Features * ComboBox - @deephaven/jsapi-components ([#2077](deephaven/web-client-ui#2077)) ([115e057](deephaven/web-client-ui@115e057)), closes [#2074](deephaven/web-client-ui#2074) ### Bug Fixes * Allow ComboBox to accept the FocusableRef for ref ([#2121](deephaven/web-client-ui#2121)) ([8fe9bad](deephaven/web-client-ui@8fe9bad)) * Ref was not being passed through for Picker ([#2122](deephaven/web-client-ui#2122)) ([a11e2ce](deephaven/web-client-ui@a11e2ce)) Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Steps to reprodude:
Run this snippet to create a partitioned table with no data:
Expected:
Actual:
The text was updated successfully, but these errors were encountered: