Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DH-16865: Partitioned table with no data displays a spinner indefinitely #1904

Closed
vbabich opened this issue Mar 25, 2024 · 6 comments · Fixed by #2110
Closed

DH-16865: Partitioned table with no data displays a spinner indefinitely #1904

vbabich opened this issue Mar 25, 2024 · 6 comments · Fixed by #2110
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vbabich
Copy link
Collaborator

vbabich commented Mar 25, 2024

Steps to reprodude:

Run this snippet to create a partitioned table with no data:

from deephaven import empty_table
t = empty_table(0).update("X=ii").partition_by("X")

Expected:

  • Table loads with no data rows

Actual:

  • Table shows a spinner, doesn't load
@vbabich vbabich added bug Something isn't working triage Issue requires triage labels Mar 25, 2024
@mattrunyon
Copy link
Collaborator

Test it works if the table is ticking and a partition is added at least. This will load for around 20s until the first row ticks in

from deephaven import time_table
t2 = time_table("PT20S").update("X=ii").where("X>0").partition_by("X")

@vbabich
Copy link
Collaborator Author

vbabich commented Mar 25, 2024

// We want to wait for the first UPDATED event instead of just getting viewport data here
// It's possible that the key table does not have any rows of data yet, so just wait until it does have one

https://github.com/deephaven/web-client-ui/blob/main/packages/iris-grid/src/IrisGrid.tsx#L2042

@mofojed mofojed removed the triage Issue requires triage label Mar 26, 2024
@mofojed mofojed added this to the April 2024 milestone Mar 26, 2024
@mofojed
Copy link
Member

mofojed commented Mar 26, 2024

We can show the empty table until the first key ticks in, in which case then we want to select that first key.

@illumon-public-sunil
Copy link

This is an issue in both Core+ and Legacy workers and is present in 1.20231218.219 as well.

Attaching images of Core+, Legacy worker and swing

image

image

image

@illumon-public-sunil
Copy link

Noticed the same behavior on a query that includes a where clause. However, the filter column used in where clause is not the partition column, behavior is the same in Legacy and Core+.

Adding empty where() to the end of the query works.

Adding the comment just to capture another use case.

@vbabich vbabich changed the title Partitioned table with no data displays a spinner indefinitely DH-16865: Partitioned table with no data displays a spinner indefinitely Apr 24, 2024
@mofojed mofojed modified the milestones: April 2024, May 2024 May 13, 2024
@mofojed mofojed modified the milestones: May 2024, June 2024 Jun 4, 2024
@AkshatJawne
Copy link
Contributor

Verified that my changes do not fix this issue, can still see the spinner. Attempted to tested changes proposed in #1953 , but running into a lot of errors (I would assume that surrounding code has changed quite a bit in the interim). Looking at how we can combine both solutions here.

@vbabich vbabich modified the milestones: June 2024, July 2024 Jul 9, 2024
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Jul 17, 2024
## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.86.0

### Features

* Add option to disable WebGL rendering
([#2134](deephaven/web-client-ui#2134))
([011eb33](deephaven/web-client-ui@011eb33))
* Core plugins refactor, XComponent framework
([#2150](deephaven/web-client-ui#2150))
([2571fad](deephaven/web-client-ui@2571fad))
* IrisGridTheme iconSize
([#2123](deephaven/web-client-ui#2123))
([58ee88d](deephaven/web-client-ui@58ee88d)),
closes [#885](deephaven/web-client-ui#885)
* Partitioned Table UI Enhancements
([#2110](deephaven/web-client-ui#2110))
([de5ce40](deephaven/web-client-ui@de5ce40)),
closes [#2079](deephaven/web-client-ui#2079)
[#2066](deephaven/web-client-ui#2066)
[#2103](deephaven/web-client-ui#2103)
[#2104](deephaven/web-client-ui#2104)
[#2105](deephaven/web-client-ui#2105)
[#2106](deephaven/web-client-ui#2106)
[#2107](deephaven/web-client-ui#2107)
[#2108](deephaven/web-client-ui#2108)
[#2109](deephaven/web-client-ui#2109)
[#2049](deephaven/web-client-ui#2049)
[#2120](deephaven/web-client-ui#2120)
[#1904](deephaven/web-client-ui#1904)


### Bug Fixes

* error when edited cell is out of grid viewport
([#2148](deephaven/web-client-ui#2148))
([3fccd43](deephaven/web-client-ui@3fccd43)),
closes [#2087](deephaven/web-client-ui#2087)

## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.2


### Bug Fixes

* Fix missing scrim background on LoadingOverlay
([#2098](deephaven/web-client-ui#2098))
([c9ed895](deephaven/web-client-ui@c9ed895))

## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.1

##
[0.85.1](deephaven/web-client-ui@v0.85.0...v0.85.1)
(2024-07-08)


### Bug Fixes

* re-export remaining types needed by dh ui from @react-types/shared
([#2132](deephaven/web-client-ui#2132))
([2119a61](deephaven/web-client-ui@2119a61))



## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.0

### Features

* ComboBox - @deephaven/jsapi-components
([#2077](deephaven/web-client-ui#2077))
([115e057](deephaven/web-client-ui@115e057)),
closes [#2074](deephaven/web-client-ui#2074)


### Bug Fixes

* Allow ComboBox to accept the FocusableRef for ref
([#2121](deephaven/web-client-ui#2121))
([8fe9bad](deephaven/web-client-ui@8fe9bad))
* Ref was not being passed through for Picker
([#2122](deephaven/web-client-ui#2122))
([a11e2ce](deephaven/web-client-ui@a11e2ce))

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants