Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename ButtonGroup to SplitButtonGroup #1997

Merged
merged 5 commits into from
May 15, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented May 8, 2024

Renaming ButtonGroup to SplitButtonGroup to avoid naming collisions with Spectrum.

resolves #2015

BREAKING CHANGE: Renamed @deephaven/components ButtonGroup to SplitButtonGroup

@dsmmcken
Copy link
Contributor

dsmmcken commented May 9, 2024

Shouldn't touch ButtonOld, I have no expectation of it having compatibility. I should just refactor it out entirely.

@dsmmcken
Copy link
Contributor

dsmmcken commented May 9, 2024

Did you mean to do that on Button?

@bmingles
Copy link
Contributor Author

bmingles commented May 9, 2024

@dsmmcken I'm planning to do this on Button as well. ButtonOld just happened to be the first attempt since it is used in the Styleguide where I was testing.

@bmingles bmingles force-pushed the 1989-spectrum-form-components branch 3 times, most recently from aff98bb to 13385ea Compare May 14, 2024 20:26
@bmingles bmingles changed the title feat: Re-exporting Spectrum ButtonGroup refactor: Rename ButtonGroup to SplitButtonGroup May 14, 2024
@bmingles bmingles marked this pull request as ready for review May 14, 2024 20:32
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.37%. Comparing base (3a6a439) to head (0b4a2f0).

❗ Current head 0b4a2f0 differs from pull request most recent head 3b8c3bc. Consider uploading reports for the commit 3b8c3bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1997      +/-   ##
==========================================
+ Coverage   46.34%   46.37%   +0.03%     
==========================================
  Files         673      668       -5     
  Lines       38762    38704      -58     
  Branches     9818     9799      -19     
==========================================
- Hits        17963    17949      -14     
+ Misses      20746    20702      -44     
  Partials       53       53              
Flag Coverage Δ
unit 46.37% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon
Copy link
Collaborator

What's the reason for the rename? Don't see anything here or in the ticket

@bmingles
Copy link
Contributor Author

What's the reason for the rename? Don't see anything here or in the ticket

It's to allow us to re-export Spectrum ButtonGroup. I updated the ticket description with details.

@bmingles bmingles requested a review from dsmmcken May 14, 2024 20:44
mofojed
mofojed previously approved these changes May 15, 2024
@bmingles bmingles requested a review from mofojed May 15, 2024 15:07
@bmingles bmingles merged commit 95a589c into deephaven:main May 15, 2024
9 checks passed
@bmingles bmingles deleted the 1989-spectrum-form-components branch May 15, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ButtonGroup to SplitButtonGroup
4 participants