Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e test status reporting incorrectly #2045

Merged
merged 3 commits into from
May 30, 2024

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented May 29, 2024

Fixes #2044

Infra PR https://github.com/deephaven/infra/pull/301

You can see the e2e-results job failed on my 2nd commit to this PR. It should fail if any of the matrix jobs fail or are cancelled.

@mattrunyon mattrunyon self-assigned this May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.36%. Comparing base (0e22d11) to head (8f77c12).

Current head 8f77c12 differs from pull request most recent head b0056b4

Please upload reports for the commit b0056b4 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2045   +/-   ##
=======================================
  Coverage   46.36%   46.36%           
=======================================
  Files         673      673           
  Lines       38780    38780           
  Branches     9826     9826           
=======================================
  Hits        17981    17981           
  Misses      20748    20748           
  Partials       51       51           
Flag Coverage Δ
unit 46.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon marked this pull request as ready for review May 30, 2024 01:51
@mattrunyon mattrunyon requested a review from mofojed May 30, 2024 01:51
@mofojed mofojed merged commit 8e6b6da into deephaven:main May 30, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
@mattrunyon mattrunyon deleted the e2e-ci-report-fix branch June 23, 2024 06:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required checks are not enforced properly for e2e
2 participants