Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow custom renderer to be passed into IrisGrid #2061

Merged
merged 2 commits into from
Jun 10, 2024
Merged

feat: Allow custom renderer to be passed into IrisGrid #2061

merged 2 commits into from
Jun 10, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Jun 6, 2024 •
edited
Loading

  • For adding your own grid/cell renderer

@mofojed
feat: Allow custom renderer to be passed into IrisGrid
5d07de0 
- For adding your own cell renderer
@mofojed mofojed self-assigned this Jun 7, 2024
@mofojed mofojed requested a review from mattrunyon June 7, 2024 15:39
@mofojed mofojed marked this pull request as ready for review June 7, 2024 15:39
mattrunyon
mattrunyon requested changes Jun 7, 2024
View reviewed changes
packages/iris-grid/src/IrisGrid.tsx Outdated Show resolved Hide resolved
@mofojed
Only keep one renderer around
de6a289 
- No need to keep more than one
@mofojed mofojed requested a review from mattrunyon June 10, 2024 19:02
@mofojed mofojed merged commit 41233b5 into deephaven:main Jun 10, 2024
10 checks passed
@mofojed mofojed deleted the grid-cell-renderer branch June 10, 2024 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattrunyon mattrunyon mattrunyon approved these changes

Assignees

@mofojed mofojed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofojed @mattrunyon