Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very slow downloading #37

Closed
pjhalsli opened this issue Nov 29, 2019 · 7 comments
Closed

very slow downloading #37

pjhalsli opened this issue Nov 29, 2019 · 7 comments

Comments

@pjhalsli
Copy link

I really love the idea of his program - not being forced to leave the terminal to look for songs in a browser - now you can just stay in the terminal and search from there. Genius. But why is it so slow compared to youtube-dl.

ytmdl was at 80% I then downloaded the same song with youtube-dl and converted it to an audio file. When it was finished ytdml was still at 96% so there's something there that takes a lot of time. It's ok fpr a song or two I guess but if you want to download say 5-6 albums (50-60 songs) it will take a lot of time. Is there a way to speed it up?

@deepjyoti30
Copy link
Owner

@pjhalsli Hey, I am aware of the issue. I have even tried downloading using chrome and it turns out it's the URL that makes the download slower towards the end.

I will have to look into youtube-dl source code to check how they implement the downloading.

@deepjyoti30
Copy link
Owner

@pjhalsli After a doing a bit of research, it turns out the download was slow because puts a ratelimit on their download links.

I was using downloader-cli to download which didn't check for ratelimits. However Youtube-dl downloader does check that and is able to download faster, so I decided to move to their downloader.

The progressbar and other stuff will still be same with the addition of a faster download. Will be added in the next release.

I'll close the issue once that release is made.

@deepjyoti30 deepjyoti30 added this to the Add in next release milestone Mar 21, 2020
@deepjyoti30
Copy link
Owner

Should be fixed in the latest release.

@pjhalsli
Copy link
Author

You are THE man

@deepjyoti30
Copy link
Owner

@pjhalsli Thanks!!

@samuelpetrosyan
Copy link

Still slow download!!?? Is there any solution?

@deepjyoti30
Copy link
Owner

@samuelpetrosyan This issue should be irrelevant to slow downloads if you're using the latest version because after this release, I moved the code to use youtube-dl all together for downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants