Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library completely broken since 0.10.0 on some devices #138

Closed
alaegin opened this issue Apr 8, 2021 · 4 comments
Closed

Library completely broken since 0.10.0 on some devices #138

alaegin opened this issue Apr 8, 2021 · 4 comments
Labels
bug Something isn't working needs-investigation

Comments

@alaegin
Copy link

alaegin commented Apr 8, 2021

Hello!
We have just started to use this library and realized that it's completely broken on some devices since 0.10.0.

Prerequisites:

  • CameraView library for video recording. Default settings with Camera2 Engine.
  • OnePlus 5 and OnePlus 7 Pro. Both use Android 10. (Also tested on Honor 9X (STK-LX1) and it works fine there).

The main problem is that the library crashes unexpectedly in some cases or transcode video with artifacts.

  • 0.9.1 works fine
  • 0.10.0 - 0.10.2 print Validator has decided that the input is fine and transcoding is not necessary. and don't transcode video at all. Link
  • 0.10.3 fails with several random issues listed below

We have several cases:

  1. Library crashes with exception java.lang.IllegalStateException: Failed to stop the muxer. Link
  2. Library crashes with exception TranscodeEngine: Unexpected error while transcoding. java.nio.BufferOverflowException. Link
  3. Library transcode video with artifacts. Link to video

The code we use to call Transcoder:

Transcoder.into(filesProvider.getTempResultFile().absolutePath)
    .apply {
        files.forEach { addDataSource(it.absolutePath) }
    }
    .setListener(...)
    .transcode().get()

It seems that rewriting #118 of the transcoder pipeline broke something important.

@alaegin alaegin changed the title Library completely broken since 0.10.0 Library completely broken since 0.10.0 on some devices Apr 8, 2021
@natario1
Copy link
Member

natario1 commented Apr 8, 2021

Can you provide the media files to reproduce these issues in the demo app?

@alaegin
Copy link
Author

alaegin commented Apr 8, 2021

Videos that were converted with artifacts on OnePlus phones but without them on the android emulator:
Part #1
Part #2

Videos from OnePlus 5
Part #1
Part #2

@jumperson
Copy link
Contributor

Library transcode video with artifacts. Link to video

I have same issue in below devices.

@natario1
Copy link
Member

IMO these issues should be fixed by latest PRs - #159, #200, #201 . Another issue that remains related to buffer overflow is tracked at #163 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-investigation
Projects
None yet
Development

No branches or pull requests

3 participants