Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dialogpt en #136

Merged
merged 17 commits into from
Apr 29, 2022
Merged

Feat/dialogpt en #136

merged 17 commits into from
Apr 29, 2022

Conversation

dilyararimovna
Copy link
Collaborator

No description provided.



def generate_response(context):
global model, tokenizer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нам точно нужны глобалы?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше бы поменять сигнатуру функции на generate_response(model, tokenizer, context):
и прокидывать их внутри фласковской функции

@mtalimanchuk mtalimanchuk self-requested a review April 29, 2022 15:32
@dilyararimovna dilyararimovna merged commit e76f25c into dev Apr 29, 2022
@dilyararimovna dilyararimovna deleted the feat/dialogpt_en branch April 29, 2022 15:47
oserikov pushed a commit that referenced this pull request Nov 21, 2024
* feat: dialogpt

* feat: dialogpt en

* fix: add dialogpt

* fix: new version

* fix: codestyle

* more configs

* more configs

* fix: emotion skill less confident

* fix: formatting

* fix: intent catcher

* fix: check for dialogpt

* fix: codestyle

* fix: signature of the function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants