From 3f2f1a2897742d7ac9f35829d032c5458e343a25 Mon Sep 17 00:00:00 2001 From: Jinzhe Zeng Date: Fri, 31 May 2024 15:55:49 -0400 Subject: [PATCH] chore: remove type embedding TODO from se_r serialize Closes #3554. I just find `se_r` never supports type embedding. It's a mistake in #3338. Signed-off-by: Jinzhe Zeng --- deepmd/tf/descriptor/se_r.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/deepmd/tf/descriptor/se_r.py b/deepmd/tf/descriptor/se_r.py index c34734a8cf..ba24142987 100644 --- a/deepmd/tf/descriptor/se_r.py +++ b/deepmd/tf/descriptor/se_r.py @@ -765,9 +765,6 @@ def serialize(self, suffix: str = "") -> dict: raise NotImplementedError("spin is unsupported") assert self.davg is not None assert self.dstd is not None - # TODO: tf: handle type embedding in DescrptSeR.serialize - # not sure how to handle type embedding - type embedding is not a model parameter, - # but instead a part of the input data. Maybe the interface should be refactored... return { "@class": "Descriptor", "type": "se_r",