From c81ce16734a993e963222020aedbf099a4373d7b Mon Sep 17 00:00:00 2001
From: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Date: Mon, 9 Sep 2024 02:46:44 -0400
Subject: [PATCH] fix(tests): fix `skip_dp` (#4111)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the test skipping logic across multiple test files to
reference the correct condition for skipping tests, enhancing the
accuracy of test execution.
- **Tests**
- Adjusted the `skip_dp` method in various test classes to improve the
control flow and alignment with specific testing scenarios.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
---
 source/tests/consistent/descriptor/test_dpa1.py        | 2 +-
 source/tests/consistent/descriptor/test_dpa2.py        | 2 +-
 source/tests/consistent/descriptor/test_se_atten_v2.py | 2 +-
 source/tests/consistent/descriptor/test_se_t_tebd.py   | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/source/tests/consistent/descriptor/test_dpa1.py b/source/tests/consistent/descriptor/test_dpa1.py
index 955b58932a..0f44ecaae1 100644
--- a/source/tests/consistent/descriptor/test_dpa1.py
+++ b/source/tests/consistent/descriptor/test_dpa1.py
@@ -177,7 +177,7 @@ def skip_dp(self) -> bool:
             use_econf_tebd,
             use_tebd_bias,
         ) = self.param
-        return CommonTest.skip_pt or self.is_meaningless_zero_attention_layer_tests(
+        return CommonTest.skip_dp or self.is_meaningless_zero_attention_layer_tests(
             attn_layer,
             attn_dotr,
             normalize,
diff --git a/source/tests/consistent/descriptor/test_dpa2.py b/source/tests/consistent/descriptor/test_dpa2.py
index d12e1094f0..144567ae58 100644
--- a/source/tests/consistent/descriptor/test_dpa2.py
+++ b/source/tests/consistent/descriptor/test_dpa2.py
@@ -235,7 +235,7 @@ def skip_dp(self) -> bool:
             use_econf_tebd,
             use_tebd_bias,
         ) = self.param
-        return CommonTest.skip_pt
+        return CommonTest.skip_dp
 
     @property
     def skip_tf(self) -> bool:
diff --git a/source/tests/consistent/descriptor/test_se_atten_v2.py b/source/tests/consistent/descriptor/test_se_atten_v2.py
index 9ae16b96fa..989fdc16e7 100644
--- a/source/tests/consistent/descriptor/test_se_atten_v2.py
+++ b/source/tests/consistent/descriptor/test_se_atten_v2.py
@@ -165,7 +165,7 @@ def skip_dp(self) -> bool:
             use_econf_tebd,
             use_tebd_bias,
         ) = self.param
-        return CommonTest.skip_pt or self.is_meaningless_zero_attention_layer_tests(
+        return CommonTest.skip_dp or self.is_meaningless_zero_attention_layer_tests(
             attn_layer,
             attn_dotr,
             normalize,
diff --git a/source/tests/consistent/descriptor/test_se_t_tebd.py b/source/tests/consistent/descriptor/test_se_t_tebd.py
index 2ddbe70a4f..d9bd00aad3 100644
--- a/source/tests/consistent/descriptor/test_se_t_tebd.py
+++ b/source/tests/consistent/descriptor/test_se_t_tebd.py
@@ -116,7 +116,7 @@ def skip_dp(self) -> bool:
             use_econf_tebd,
             use_tebd_bias,
         ) = self.param
-        return CommonTest.skip_pt
+        return CommonTest.skip_dp
 
     @property
     def skip_tf(self) -> bool: