Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Move the model output bias to atomic model #3593

Closed
wanghan-iapcm opened this issue Mar 25, 2024 · 0 comments · Fixed by #3642
Closed

[Feature Request] Move the model output bias to atomic model #3593

wanghan-iapcm opened this issue Mar 25, 2024 · 0 comments · Fixed by #3642
Assignees

Comments

@wanghan-iapcm
Copy link
Collaborator

Summary

current the bias is implemented as an attribute of the fitting network. however, not all atomic models has a fitting net.
conceptually it is better to implement the bias as an attribute of an atomic model.

Detailed Description

  1. the bias is an attribute of an atomic model.
  2. an atomic model implements the compute_output_stats method. the BaseAtomicModel may provide a default implementation.
  3. the bias is automatically applied in the forward_common_atomic of the BaseAtomicModel.

Further Information, Files, and Links

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants