Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move torch to a dependency group #27

Open
phschoepf opened this issue Nov 6, 2024 · 1 comment
Open

Move torch to a dependency group #27

phschoepf opened this issue Nov 6, 2024 · 1 comment
Assignees

Comments

@phschoepf
Copy link
Contributor

Since torch/torchvision is still listed in the pyproject.toml, it is currently impossible (aside from manually modifying the dependencies) to use the package without installing torch. Thus, torch should be moved to an optional dependency group.

Unfortunately, this means that torch can't be the default anymore since it won't be installed by default. And there are no "negative entries" for optional dependency groups.

@Paethon
Copy link
Contributor

Paethon commented Nov 6, 2024

For me personally, this is only a test until we get feedback from Eng whether it is worth actually removing torch or not. For now, torch is still the preferred and recommended way of doing this in my opinion.

So might be fixed at some time in the future when this is settled. But then we probably also have to improve performance of the non-torch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants