Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression processor label standardization inconsistencies #452

Closed
rohanag opened this issue Jul 10, 2020 · 3 comments · Fixed by #456
Closed

regression processor label standardization inconsistencies #452

rohanag opened this issue Jul 10, 2020 · 3 comments · Fixed by #456
Labels
bug Something isn't working

Comments

@rohanag
Copy link
Contributor

rohanag commented Jul 10, 2020

Describe the bug
Problem with label standardization in regression processor. Label mean and std deviation are being calculated for train set, then those values are being overwritten with the same calculation for dev and test set link to code
After that, standardization is not actually performed on any data because of key mismatch over here. Instead of checking for the "label" key, you must look for self.tasks["regression"]["label_name"]

Error message
Silent error.

Expected behavior
RegressionProcessor should store regression label mean and std dev values only for train set. And standardization must be performed on the actual labels.

Additional context

To Reproduce
add print statements to view the output of this function and you will see that standardization of regression label is not taking place.

System:

  • OS: Ubuntu 16.04.5 LTS
  • GPU/CPU: Both
  • FARM version: 0.4.5
@rohanag rohanag added the bug Something isn't working label Jul 10, 2020
@rohanag
Copy link
Contributor Author

rohanag commented Jul 10, 2020

I'm also trying to push a fix but I get
fatal: unable to access 'https://github.com/deepset-ai/FARM.git/': The requested URL returned error: 403
Just wondering if the problem is on my end, or if there is an actual permission issue.

@tholor
Copy link
Member

tholor commented Jul 10, 2020

@rohanag thanks for spotting this. We would highly appreciate a fix!
When do you get the above access error? Did you maybe try to push directly to the FARM repo? In order to create a PR you'll need to fork the repo, push your changes to a branch in your repo, and then create a pull request from there.

@rohanag
Copy link
Contributor Author

rohanag commented Jul 10, 2020

Ah yes ofc, I forgot forking! sending one PR shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants