Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting metadata for ByteStream when created from file or from string #6217

Closed
ZanSara opened this issue Nov 2, 2023 · 1 comment · Fixed by #6857
Closed

Allow setting metadata for ByteStream when created from file or from string #6217

ZanSara opened this issue Nov 2, 2023 · 1 comment · Fixed by #6857
Assignees
@ZanSara
Labels
2.x Related to Haystack v2.0 good first issue Good for newcomers P2 Medium priority, add to the next sprint if no P1 available
Milestone
2.0.0

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Nov 2, 2023

Right now ByteStream supports metadata, but only when initialized directly. On the contrary, from_file_path and from_string don't let users set any metadata, and on top of that the class is frozen, so the metadata cannot be added after creation.

We should:

  • Unfreeze ByteStream
  • Add a metadata parameter to the two methods.
@masci
Copy link
Contributor

masci commented Jan 11, 2024

Let's unfreeze the dataclass

@masci masci added P2 Medium priority, add to the next sprint if no P1 available 2.x Related to Haystack v2.0 good first issue Good for newcomers labels Jan 11, 2024
@masci masci added this to the 2.0.0 milestone Jan 11, 2024
@ZanSara ZanSara self-assigned this Jan 30, 2024
@ZanSara ZanSara mentioned this issue Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZanSara ZanSara

Labels
2.x Related to Haystack v2.0 good first issue Good for newcomers P2 Medium priority, add to the next sprint if no P1 available
Projects
None yet
Milestone
2.0.0
2 participants
@masci @ZanSara