Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bring ui into monorepo #349

Merged
merged 12 commits into from
Apr 15, 2024
Merged

chore: bring ui into monorepo #349

merged 12 commits into from
Apr 15, 2024

Conversation

andrewrisse
Copy link
Contributor

@andrewrisse andrewrisse commented Apr 3, 2024

Integrates the "new UI (lfaiui) into the monorepo.

New naming convention is "leapfrogai-ui"

Includes Keycloak code that will not work until Supabase is deployed in our clusters.

We will leave leapfrog-demo deployed as is since it does not use Keycloak yet.

closes #344
closes #307

@andrewrisse andrewrisse requested a review from a team as a code owner April 3, 2024 19:04
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit a5cd1a4
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/661d3d34c573e80008176ba2

Copy link
Member

@gerred gerred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing some initial change requests since this is gonna be a chonky review

packages/ui/chart/templates/ui/deployment.yaml Outdated Show resolved Hide resolved
packages/ui/chart/templates/ui/service.yaml Outdated Show resolved Hide resolved
@gphorvath
Copy link
Contributor

If Supabase is a resource we are sharing between the API DB and UI, do we need to move the Supabase directory up a level? Not totally sure how that works.
@andrewrisse

@andrewrisse
Copy link
Contributor Author

andrewrisse commented Apr 4, 2024

If Supabase is a resource we are sharing between the API DB and UI, do we need to move the Supabase directory up a level? Not totally sure how that works. @andrewrisse

That directory is for running Supabase locally with the UI although it does contain some migrations the frontend needs when setting up Supabase. I wonder if these could be moved up to a parent directory.

@gerred I'm thinking consolating the supabase migrations and setup should be a separate issue once we have a sucessful deployment. I still need this in my section of the repo until that's in place

@YrrepNoj YrrepNoj added this to the SPRINT milestone Apr 4, 2024
@gerred
Copy link
Member

gerred commented Apr 5, 2024

If Supabase is a resource we are sharing between the API DB and UI, do we need to move the Supabase directory up a level? Not totally sure how that works. @andrewrisse

That directory is for running Supabase locally with the UI although it does contain some migrations the frontend needs when setting up Supabase. I wonder if these could be moved up to a parent directory.

@gerred I'm thinking consolating the supabase migrations and setup should be a separate issue once we have a sucessful deployment. I still need this in my section of the repo until that's in place

Agreed on migrations later.

@gerred gerred self-requested a review April 9, 2024 15:29
gerred
gerred previously approved these changes Apr 9, 2024
@gerred
Copy link
Member

gerred commented Apr 9, 2024

Read through all the Svelte parts, looks like a really good start. We should consider something a little more robust for migrations.

@gerred gerred merged commit 0463af9 into main Apr 15, 2024
8 checks passed
@gerred gerred deleted the consolidate-ui branch April 15, 2024 15:36
andrewrisse added a commit that referenced this pull request Apr 17, 2024
* chore: bring ui into monorepo

* chore: remove streaming api test, fix ui flicker

* chore: additional tests

* chore: additional tests with todos

* fix: lower resource reqs/limits, remove sa

* chore: more api tests

* chore: more api tests 2

* fix: set resource limits to 0

* fix: delete .github dir under ui folder

* chore: remove husky

---------

Co-authored-by: Gerred Dillon <gerred@defenseunicorns.com>
Signed-off-by: Andrew Risse <andrewrisse@gmail.com>
andrewrisse added a commit that referenced this pull request Apr 17, 2024
* chore: bring ui into monorepo

* chore: remove streaming api test, fix ui flicker

* chore: additional tests

* chore: additional tests with todos

* fix: lower resource reqs/limits, remove sa

* chore: more api tests

* chore: more api tests 2

* fix: set resource limits to 0

* fix: delete .github dir under ui folder

* chore: remove husky

---------

Co-authored-by: Gerred Dillon <gerred@defenseunicorns.com>
Signed-off-by: Andrew Risse <andrewrisse@gmail.com>
andrewrisse added a commit that referenced this pull request Apr 17, 2024
* chore: bring ui into monorepo

* chore: remove streaming api test, fix ui flicker

* chore: additional tests

* chore: additional tests with todos

* fix: lower resource reqs/limits, remove sa

* chore: more api tests

* chore: more api tests 2

* fix: set resource limits to 0

* fix: delete .github dir under ui folder

* chore: remove husky

---------

Co-authored-by: Gerred Dillon <gerred@defenseunicorns.com>
Signed-off-by: Andrew Risse <andrewrisse@gmail.com>
andrewrisse added a commit that referenced this pull request Apr 17, 2024
* chore: bring ui into monorepo

* chore: remove streaming api test, fix ui flicker

* chore: additional tests

* chore: additional tests with todos

* fix: lower resource reqs/limits, remove sa

* chore: more api tests

* chore: more api tests 2

* fix: set resource limits to 0

* fix: delete .github dir under ui folder

* chore: remove husky

---------

Co-authored-by: Gerred Dillon <gerred@defenseunicorns.com>
andrewrisse added a commit that referenced this pull request Apr 18, 2024
* chore: bring ui into monorepo

* chore: remove streaming api test, fix ui flicker

* chore: additional tests

* chore: additional tests with todos

* fix: lower resource reqs/limits, remove sa

* chore: more api tests

* chore: more api tests 2

* fix: set resource limits to 0

* fix: delete .github dir under ui folder

* chore: remove husky

---------

Co-authored-by: Gerred Dillon <gerred@defenseunicorns.com>
andrewrisse added a commit that referenced this pull request Apr 18, 2024
* chore: bring ui into monorepo

* chore: remove streaming api test, fix ui flicker

* chore: additional tests

* chore: additional tests with todos

* fix: lower resource reqs/limits, remove sa

* chore: more api tests

* chore: more api tests 2

* fix: set resource limits to 0

* fix: delete .github dir under ui folder

* chore: remove husky

---------

Co-authored-by: Gerred Dillon <gerred@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(ui): pull ui into monorepo chore(ui): validate user input to forms and apis
4 participants