Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

407 Add test workflow for leapfrogai_ui #439

Merged
merged 24 commits into from
Apr 30, 2024
Merged

407 Add test workflow for leapfrogai_ui #439

merged 24 commits into from
Apr 30, 2024

Conversation

jalling97
Copy link
Contributor

@jalling97 jalling97 commented Apr 24, 2024 •
edited
Loading

  • Adds a workflow for running the existing unit tests within the new UI.
  • Adds a workflow to scan for active secrets using trufflehog
  • Adds UI-focused linting checks to the existing lint workflow
  • Adds eslint and prettier to pre-commit checks

After the workflows were added, linting changes were applied to this PR to get the UI compliant with the linter/formatter

@jalling97 jalling97 linked an issue Apr 24, 2024 that may be closed by this pull request
ci: Create test workflow for svelte code (e2e) #407
Closed
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited
Loading

✅ Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 0ef7cc3
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66311f7970af7a0008652b9e

@jalling97 jalling97 marked this pull request as ready for review April 25, 2024 20:30
@jalling97 jalling97 requested a review from a team as a code owner April 25, 2024 20:30
@andrewrisse
Copy link
Contributor

andrewrisse commented Apr 25, 2024 •
edited
Loading

I disabled the 'no-undef' rule for eslint because Typescript is already checking for this and gives no errors.
Docs Reference: https://typescript-eslint.io/troubleshooting/#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors

justinthelaw
justinthelaw reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@justinthelaw justinthelaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question and some minor things!

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
.github/workflows/secret-scan.yaml Outdated Show resolved Hide resolved
.github/workflows/secret-scan.yaml Show resolved Hide resolved
.github/workflows/ui-test.yaml Outdated Show resolved Hide resolved
.github/workflows/ui-test.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
gerred
gerred previously approved these changes Apr 26, 2024
View reviewed changes
@gerred
Copy link
Member

gerred commented Apr 26, 2024

all lgtm pending @justinthelaw's feedback being resolved.

gerred
gerred reviewed Apr 26, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@gerred
Copy link
Member

gerred commented Apr 29, 2024

fix conflicts then lgtm

gerred
gerred previously approved these changes Apr 29, 2024
View reviewed changes
gerred
gerred previously approved these changes Apr 30, 2024
View reviewed changes
YrrepNoj
YrrepNoj requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small change requests.

.github/workflows/secret-scan.yaml Outdated Show resolved Hide resolved
.github/workflows/ui-test.yaml Show resolved Hide resolved
@jalling97 jalling97 requested a review from YrrepNoj April 30, 2024 17:44
YrrepNoj
YrrepNoj approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YrrepNoj YrrepNoj merged commit b5aa668 into main Apr 30, 2024
13 checks passed
@YrrepNoj YrrepNoj deleted the 407-ci-create-test-workflow-for-svelte-code-e2e branch April 30, 2024 18:45
@github-actions github-actions bot mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrisse andrewrisse andrewrisse left review comments

@justinthelaw justinthelaw justinthelaw left review comments

@YrrepNoj YrrepNoj YrrepNoj approved these changes

@gerred gerred gerred left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: Create test workflow for svelte code (e2e)
5 participants
@jalling97 @andrewrisse @gerred @YrrepNoj @justinthelaw