Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing API variable naming - confusing #734

Closed
gscallon opened this issue Jul 8, 2024 · 1 comment · Fixed by #768
Closed

Exposing API variable naming - confusing #734

gscallon opened this issue Jul 8, 2024 · 1 comment · Fixed by #768
Assignees
Labels
possible-bug 🐛 Something may not be working

Comments

@gscallon
Copy link
Contributor

gscallon commented Jul 8, 2024

Environment

Device and OS: Ubuntu
App/package versions: uds and all other dependencies up-to-date
Kubernetes distro being used: k3d
Other:

Steps to reproduce

  1. Attempt to expose the API in the LeapfrogAI UDS bundle
  2. Put down expose_openai_schema:true
  3. The API exposure does not work
  4. Realize it is actually expose_openapi_schema:true
  5. The API is exposed and works properly

Expected result

We have had 3 different users thus far mess up the copy/paste or accidentally use openai in place of openapi.

Normally, I would attribute this to user error, but three different users making the same mistake represents a pattern.

Actual Result

The API is not exposed properly when the wrong variable is used.

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

Nice-to-have. May be rendered obsolete if the API is exposed by default once the long-lived API key branch is merged into the project.

Additional Context

CC @unicorn-kp

@gscallon gscallon added the possible-bug 🐛 Something may not be working label Jul 8, 2024
@gphorvath gphorvath self-assigned this Jul 8, 2024
@gphorvath gphorvath linked a pull request Jul 8, 2024 that will close this issue
@gphorvath
Copy link

in #561 proposing to rename to EXPOSE_API

@gphorvath gphorvath reopened this Jul 12, 2024
@gphorvath gphorvath removed a link to a pull request Jul 12, 2024
@gphorvath gphorvath linked a pull request Jul 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible-bug 🐛 Something may not be working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants