Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(whisper): Pass through variables down to whisper #840

Merged
merged 11 commits into from
Jul 30, 2024
Merged

chore(whisper): Pass through variables down to whisper #840

merged 11 commits into from
Jul 30, 2024

Conversation

CollectiveUnicorn
Copy link
Contributor

Ensures that all variables are passed down to the actual whisper model

  • language, temperature, prompt

@CollectiveUnicorn CollectiveUnicorn requested a review from a team as a code owner July 25, 2024 22:41
@netlify Netlify
Copy link

netlify bot commented Jul 25, 2024 •
edited
Loading

✅ Deploy Preview for leapfrogai-docs ready!

Name Link
🔨 Latest commit 4122919
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66a93eab5c91860008fc1c04
😎 Deploy Preview https://deploy-preview-840--leapfrogai-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 40 (🟢 up 3 from production)
Accessibility: 98 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

justinthelaw
justinthelaw previously approved these changes Jul 25, 2024
View reviewed changes
gphorvath
gphorvath previously approved these changes Jul 26, 2024
View reviewed changes
gphorvath
gphorvath reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@gphorvath gphorvath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments... also, looking at the pipeline it looks like the response started repeating itself... not sure if there is a config needed or if that is just a one off.

packages/whisper/main.py Outdated Show resolved Hide resolved
packages/whisper/main.py Show resolved Hide resolved
packages/whisper/main.py Outdated Show resolved Hide resolved
@CollectiveUnicorn CollectiveUnicorn merged commit 4e8092a into main Jul 30, 2024
20 checks passed
@CollectiveUnicorn CollectiveUnicorn deleted the pass-whisper-variables branch July 30, 2024 22:19
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinthelaw justinthelaw justinthelaw approved these changes

@gphorvath gphorvath Awaiting requested review from gphorvath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CollectiveUnicorn @gphorvath @justinthelaw