Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validate): fix related observations when empty #448

Merged
merged 2 commits into from
May 30, 2024

Conversation

brandtkeller
Copy link
Member

Description

Validation fails when the assessment results model contains a finding with an empty array for related-observations.

Related Issue

Fixes #447

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented May 29, 2024

Deploy Preview for lula-docs canceled.

Name Link
🔨 Latest commit aff5389
🔍 Latest deploy log https://app.netlify.com/sites/lula-docs/deploys/6658795ef46a7a0008a93fd4

@brandtkeller brandtkeller merged commit f6f6993 into main May 30, 2024
8 checks passed
@brandtkeller brandtkeller deleted the 447_ar_validation branch May 30, 2024 13:11
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Aug 5, 2024
This was referenced Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Validation Errors when validating with existing AR
3 participants