Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use v8go to run Pepr modules #1149

Closed
cmwylie19 opened this issue Sep 18, 2024 · 2 comments
Closed

use v8go to run Pepr modules #1149

cmwylie19 opened this issue Sep 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cmwylie19
Copy link
Contributor

cmwylie19 commented Sep 18, 2024

Is your feature request related to a problem? Please describe.

related issue: #745

We think there is a chunking problem between Go and JavaScript which makes the watch get intermittent and silent failures. We think using Go from a Pepr modules to speak to kube-apiserver (also Go) could solve the problem. This would not affect the api surface area
link

Describe the solution you'd like

  • Given we are running v8go
  • When a watch is occurring
  • Then events will not be silently dropped

Describe alternatives you've considered

(optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@cmwylie19 cmwylie19 added the enhancement New feature or request label Sep 18, 2024
@cmwylie19 cmwylie19 self-assigned this Sep 21, 2024
@mjnagel
Copy link
Contributor

mjnagel commented Sep 25, 2024

Is there any concern with the active maintenance of v8go? It looks like the last release was a year and a half ago, last commit was around the same time, and it appears to still be on go 1.17. There's also a decent amount of open issues and PRs, I think I might be concerned about relying on it for such a core part of pepr/kfc - not sure there is a lot of confidence that we could get issues fixed, CVEs resolved, etc in a timely manner.

@cmwylie19
Copy link
Contributor Author

Is there any concern with the active maintenance of v8go? It looks like the last release was a year and a half ago, last commit was around the same time, and it appears to still be on go 1.17. There's also a decent amount of open issues and PRs, I think I might be concerned about relying on it for such a core part of pepr/kfc - not sure there is a lot of confidence that we could get issues fixed, CVEs resolved, etc in a timely manner.

Definitely were concerns about the supportability, there is Sobek from Grafana that is more supported but the ultimate hesitation was around having to maintain support for native node libraries in Go and inject them into the runtime environment.

Here is how our evaluation.

We are going to close this issue for now as we focus on implementing native fetch and native stream to improve the watch connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants