Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow variable type: file in uds bundles #417

Closed
brianrexrode opened this issue Feb 12, 2024 · 9 comments · Fixed by #631
Closed

Allow variable type: file in uds bundles #417

brianrexrode opened this issue Feb 12, 2024 · 9 comments · Fixed by #631
Assignees
Labels
enhancement New feature or request

Comments

@brianrexrode
Copy link

Is your feature request related to a problem? Please describe

It would be nice to have the ability to pass files as variables with uds bundles (ex. cert/key files)

Describe the solution you'd like

  • If I want to override the default tls.crt/tls.key for an ingress-gateway
  • I could set the TLS.CRT variable to point to a file
  • and the cert/key file would get added to the ingress-gateway deployment

Describe alternatives you've considered

(optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@brianrexrode brianrexrode added the enhancement New feature or request label Feb 12, 2024
@benmountjoy111
Copy link

HCND would also like this feature

@UncleGedd
Copy link
Collaborator

This is an oldie! I'm assuming still relevant though?

@benmountjoy111
Copy link

I would say yes. We would like a way to specify files like we could with zarf (for keys/certs, as Rex is also wanting to do)

@UncleGedd
Copy link
Collaborator

awesome, we'll prioritize this one; you should see it in the next couple of releases

@TristanHoladay
Copy link
Collaborator

@benmountjoy111 @brianrexrode just wanted to confirm that the priority for this is to work with variables (either setting zarf vars or helm override vars) not values in helm overrides. Is that correct?

@benmountjoy111
Copy link

correct. Want to be able to set uds/zarf vars to a file (particularly for certs/keys).

@TristanHoladay
Copy link
Collaborator

@benmountjoy111 @brianrexrode do y'all base64 encode your certs/keys yourselves or do you rely on something like SOPS? Just want to make sure we emulate the process people are used to.

@benmountjoy111
Copy link

our intent (tho we are not there yet) is to use SOPS so that we can check in our certs/keys encrypted. Right now we use github secrets and echo them to disk in our workflows (not the greatest solution). But i think handling the encryption/decryption of the files would be outside of this issue (i.e., we'd have to handle that, and once it's unencrypted, we could tell uds-cli to use it). Just my 2 cents tho

@TristanHoladay
Copy link
Collaborator

cool. kinda figured y'all would be ok doing all that before passing things on to cli, but wanted to make sure we weren't going to create a negative user experience if the expectation was for us to handle those kinds of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants