Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle override names must be defined IN_UPPERCASE #427

Closed
zachariahmiller opened this issue Feb 13, 2024 · 0 comments · Fixed by #433
Closed

bundle override names must be defined IN_UPPERCASE #427

zachariahmiller opened this issue Feb 13, 2024 · 0 comments · Fixed by #433
Assignees
Labels
possible-bug Something may not be working

Comments

@zachariahmiller
Copy link
Contributor

Environment

Device and OS: N/A
App version: 0.9.0
Kubernetes distro being used: N/A
Other:

uds cli used to not care about the case for the names of bundle overrides. At some point this behavior changed such that an override defined in lowercase would not have the respective value in uds-config.yaml assigned to it

Steps to reproduce

To reproduce, take the bundle overrides test case

and change SECURITY_CTX to security_ctx.

Expected result

variable in uds-config.yaml gets read in and passed through to the helm chart

Actual Result

It wont happen. Note: if a default value is defined, it propogate to the vlaues file appropriately even if the name is lowercase. This issue is specifically that the value is getting dropped between the bundle-config and the actual overriding of the helm chart.

Visual Proof (screenshots, videos, text, etc)

Confirmed with Darcy this morning

Severity/Priority

Additional Context

Add any other context or screenshots about the technical debt here.

@zachariahmiller zachariahmiller added the possible-bug Something may not be working label Feb 13, 2024
@zachariahmiller zachariahmiller changed the title bundle override names must be define IN_UPPERCASE bundle override names must be defined IN_UPPERCASE Feb 13, 2024
@decleaver decleaver self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible-bug Something may not be working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants