Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if creating a bundle while setting --tmpdir <dir>, /tmp is still used #430

Closed
zachariahmiller opened this issue Feb 14, 2024 · 0 comments · Fixed by #431
Closed

if creating a bundle while setting --tmpdir <dir>, /tmp is still used #430

zachariahmiller opened this issue Feb 14, 2024 · 0 comments · Fixed by #431
Assignees
Labels
possible-bug Something may not be working

Comments

@zachariahmiller
Copy link
Contributor

Environment

Device and OS: rhel-like
App version:
Kubernetes distro being used: rke2
Other:

Steps to reproduce

  1. try to create a bundle specifying --tmpdir <dir>
  2. see it still use /tmp

Expected result

uses the passed in directory

Actual Result

uses /tmp

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

Additional Context

From discussion with @Noxsios :

we need to standardize creating tmp dirs across the board. rn any caller of Zarf's utils.MakeTempDirectory is going to use the systems tmp dirs unless you pass a dir string. (There's a bunch of bad behavior w/ this in Zarf as well thinking more on it)

@justin-o12 FYSA i created this issue to track what you ran into.

@UncleGedd @decleaver I will link more details internally.

@zachariahmiller zachariahmiller added the possible-bug Something may not be working label Feb 14, 2024
@decleaver decleaver self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible-bug Something may not be working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants