Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up gosec as part of the linter #448

Closed
UncleGedd opened this issue Feb 21, 2024 · 3 comments
Closed

Set up gosec as part of the linter #448

UncleGedd opened this issue Feb 21, 2024 · 3 comments

Comments

@UncleGedd
Copy link
Collaborator

UncleGedd commented Feb 21, 2024 •
edited
Loading

Set up gosec as part of golangci-lint. Ensure this gets run as part of the precommit and in our workflows
@naveensrinivasan
Copy link
Member

Yes, But it should be part of the CI.

@naveensrinivasan naveensrinivasan mentioned this issue Feb 27, 2024
Merged
5 tasks
@TristanHoladay
Copy link
Collaborator

i believe this is now running in our pre-commit hook when it calls golangci with our .golangci.yml. And then that is run in CI in the scan-lint.yaml

@UncleGedd
Copy link
Collaborator Author

i believe this is now running in our pre-commit hook when it calls golangci with our .golangci.yml. And then that is run in CI in the scan-lint.yaml

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@naveensrinivasan @TristanHoladay @UncleGedd