Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an output flag for local bundle create #461

Closed
UncleGedd opened this issue Feb 23, 2024 · 1 comment · Fixed by #547
Closed

Add an output flag for local bundle create #461

UncleGedd opened this issue Feb 23, 2024 · 1 comment · Fixed by #547
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@UncleGedd
Copy link
Collaborator

Description

Today we do a uds create -o to output an OCI registry, let's also ensure we can do this for local directories

@UncleGedd UncleGedd added possible-bug Something may not be working good first issue Good for newcomers enhancement New feature or request and removed possible-bug Something may not be working labels Feb 23, 2024
@TristanHoladay TristanHoladay self-assigned this Apr 3, 2024
@UncleGedd
Copy link
Collaborator Author

UncleGedd commented Apr 3, 2024

Discussed with @TristanHoladay :

  • if the -o file path doesn't exist we should create the path (just like in Zarf)
  • we can use a heuristic to determine if the -o string is a URL or local path (could use helpers.IsDir() and/or url.Parse() from the net/url pkg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants