From d1aae7a4977827692c43ad43d82af25e4e52c3f2 Mon Sep 17 00:00:00 2001
From: Darcy Cleaver <darcy@defenseunicorns.com>
Date: Thu, 15 Feb 2024 12:35:45 -0700
Subject: [PATCH] fix: case sensitivity in override vars

---
 src/pkg/bundle/deploy.go                           | 2 ++
 src/test/bundles/07-helm-overrides/uds-bundle.yaml | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/pkg/bundle/deploy.go b/src/pkg/bundle/deploy.go
index 45c8cb5d..e2fb7a0f 100644
--- a/src/pkg/bundle/deploy.go
+++ b/src/pkg/bundle/deploy.go
@@ -338,6 +338,8 @@ func (b *Bundle) processOverrideValues(overrideMap *map[string]map[string]*value
 func (b *Bundle) processOverrideVariables(overrideMap *map[string]map[string]*values.Options, pkgName string, variables *[]types.BundleChartVariable, componentName string, chartName string) error {
 	for _, v := range *variables {
 		var overrideVal interface{}
+		// Ensuring variable name is upper case since comparisons are being done against upper case env and config variables
+		v.Name = strings.ToUpper(v.Name)
 		// check for override in env vars
 		if envVarOverride, exists := os.LookupEnv(strings.ToUpper(config.EnvVarPrefix + v.Name)); exists {
 			if err := addOverrideValue(*overrideMap, componentName, chartName, v.Path, envVarOverride); err != nil {
diff --git a/src/test/bundles/07-helm-overrides/uds-bundle.yaml b/src/test/bundles/07-helm-overrides/uds-bundle.yaml
index 8912eef6..a0019dc3 100644
--- a/src/test/bundles/07-helm-overrides/uds-bundle.yaml
+++ b/src/test/bundles/07-helm-overrides/uds-bundle.yaml
@@ -29,7 +29,7 @@ packages:
               value:
                 customAnnotation: "customValue"
           variables:
-            - name: UI_COLOR
+            - name: ui_color
               path: "podinfo.ui.color"
               description: "Set the color for podinfo's UI"
               default: "blue"