feat: embed tls certs in istio package #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachariahmiller
approved these changes
Nov 13, 2023
mjnagel
reviewed
Nov 13, 2023
| @@ -15,8 +15,8 @@ tls: | |||
| # The secret name for the TLS certificate when not using passthrough mode | |||
| secretName: gw-cert | |||
|
|
|||
| # For TLS SIMPLE mode, the TLS certificate data for the gateway | |||
| # For TLS SIMPLE mode, the TLS certificate data for the gateway (not base64 encoded) | |||
There was a problem hiding this comment.
I think I'm too late to the review, but I think this update to the comment is confusing since the value passed in here has to be base64 encoded. Tracking that the secret does not do the base64 encoding anymore, but the value comment should be written from a user perspective (something like For TLS SIMPLE mode, the base64 encoded TLS certificate data for the gateway).
If you all agree I can PR the small change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Embed the uds.dev certs into the package by default in preparation for future helm override features. In the interim, the Node version still works, and the README was updated to explain this.
Type of change
Checklist before merging