feat: add monitoring and logging #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachariahmiller
changed the title
mjnagel
reviewed
Nov 13, 2023
…ve grafana validate
zachariahmiller
changed the title
mjnagel
reviewed
Nov 14, 2023
Signed-off-by: Zachariah Miller <zachariah.miller@defenseunicorns.com>
mjnagel
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Mostly some nits on extra things I noticed when scrolling through. 2 other broad comments probably to track as follow on issues:
- Some of these charts have new versions available upstream vs what is here
- Image stuff...some of the values we have for repo/image aren't really needed but pending flavor discussions might be?
capabilities/promtail/chart/templates/istio/peer-authentication.yaml
Outdated
Show resolved
Hide resolved
jeff-mccoy
reviewed
Nov 15, 2023
jeff-mccoy
reviewed
Nov 15, 2023
jeff-mccoy
reviewed
Nov 15, 2023
jeff-mccoy
reviewed
Nov 15, 2023
jeff-mccoy
reviewed
Nov 15, 2023
jeff-mccoy
reviewed
Nov 15, 2023
jeff-mccoy
previously requested changes
Nov 15, 2023
|
assuming the ci passes this should be good to go |
zachariahmiller
dismissed
jeff-mccoy’s stale review
changes were made per requested changes.
|
Added the debug stuff because something looked like it was hanging and this time it passed, probably something we need to wait and see if we can reproduce with debug logs next time.
|
jeff-mccoy
approved these changes
Nov 16, 2023
This was referenced Nov 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add promtail, fix netpols, add prometheus to standard-package, add grafana
Type of change
Checklist before merging