Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry1 flavor is currently untested on nightly eks test #504

Closed
zack-is-cool opened this issue Jun 21, 2024 · 2 comments · Fixed by #679
Closed

Registry1 flavor is currently untested on nightly eks test #504

zack-is-cool opened this issue Jun 21, 2024 · 2 comments · Fixed by #679
Assignees
Labels
ci Issues pertaining to CI / Pipelines / Testing enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@zack-is-cool
Copy link
Member

zack-is-cool commented Jun 21, 2024

Describe what should be investigated or refactored

Ideally, the registry1 flavor would be tested in the nightly eks tests. Bonus points if the eks tests occur in govcloud as this package is currently used in AWS Govcloud on EKS.

Links to any relevant code

Nightly eks test

https://github.com/defenseunicorns/uds-core/blob/main/.github/workflows/test-eks.yaml

Related issues

#213

edit: updated w/ correct info

@mjnagel
Copy link
Contributor

mjnagel commented Jun 21, 2024

Just to clarify - registry1 is tested on all PRs and before release, but only on k3d. The missing part is nightly (EKS) tests of registry1.

@zack-is-cool zack-is-cool changed the title Registry1 flavor is currently untested Registry1 flavor is currently untested on nightly eks test Jun 22, 2024
@mjnagel mjnagel added enhancement New feature or request ci Issues pertaining to CI / Pipelines / Testing labels Jul 2, 2024
@mjnagel mjnagel added the good first issue Good for newcomers label Jul 26, 2024
@mjnagel
Copy link
Contributor

mjnagel commented Jul 26, 2024

This should be relatively quick to add to our EKS workflow. Some pointers for this:

  • Add a matrix for flavor (similar to the existing k3d PR tests)
  • Pass the flavor into the create task with --set to ensure we create the necessary package (this is used in the task during package create)
  • Nice to have - also add unicorn flavor to the matrix, setup/auth to cgr should be handled for you already so this should be a simple addition

@UnicornChance UnicornChance self-assigned this Aug 16, 2024
@UnicornChance UnicornChance linked a pull request Aug 19, 2024 that will close this issue
5 tasks
@mjnagel mjnagel added this to the 0.26.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues pertaining to CI / Pipelines / Testing enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants