You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what should be investigated or refactored
In the current state of things deletions happen in a watch in our pepr code. As we manage additional "external resources" (such as keycloak clients), blocking on that deletion is critical to prevent errors when a rapid delete + create process happens. Kubernetes finalizers feel like the right solution to ensure that someone cannot reuse a Package name before the previous one is fully cleaned up.
Links to any relevant code
This block of code is the most relevant - note that these are two separate flows and there is currently no "block on delete" in here:
Describe what should be investigated or refactored
In the current state of things deletions happen in a watch in our pepr code. As we manage additional "external resources" (such as keycloak clients), blocking on that deletion is critical to prevent errors when a rapid delete + create process happens. Kubernetes finalizers feel like the right solution to ensure that someone cannot reuse a
Package
name before the previous one is fully cleaned up.Links to any relevant code
This block of code is the most relevant - note that these are two separate flows and there is currently no "block on delete" in here:
uds-core/src/pepr/operator/index.ts
Lines 43 to 60 in d71d83e
Additional context
https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/
The text was updated successfully, but these errors were encountered: