Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Gitlab to fail closed on SAML login #166

Closed
ntwkninja opened this issue Jul 15, 2024 · 0 comments · Fixed by #167
Closed

Default Gitlab to fail closed on SAML login #166

ntwkninja opened this issue Jul 15, 2024 · 0 comments · Fixed by #167
Labels
enhancement ✨ New feature or request

Comments

@ntwkninja
Copy link
Member

Is your feature request related to a problem? Please describe.

If a required_group is not specific in the GitLab SAML configuration, any authenticated user can access the app.

If you do not set required_groups or leave the setting empty, anyone with proper authentication can use the service.

Describe the solution you'd like

  • Given a new user is registered to the SAML IdP
  • When they access gitlab.
  • Then access is denied

Describe alternatives you've considered

(optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose requiredGroups in sso config defenseunicorns/uds-package-gitlab
1 participant
@ntwkninja