chore: add architecture to save logs suffix on tag-and-release #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwyles
changed the title
Racer159
reviewed
Jun 20, 2024
Racer159
approved these changes
Jun 20, 2024
Racer159
pushed a commit
that referenced
this pull request
Jul 31, 2024
🤖 I have created a release *beep* *boop* --- ## [10.6.0-uds.0](v9.9.5-uds.1...v10.6.0-uds.0) (2024-07-31) ### ⚠ BREAKING CHANGES * update to SonarQube 10, migrate to upstream chart, add `unicorn` CGR flavor ([#100](#100)) * remove egress anywhere for SSO ([#102](#102)) ### Miscellaneous * add architecture to save logs suffix on tag-and-release ([#92](#92)) ([5fbe70c](5fbe70c)) * **deps:** update sonarqube support dependencies ([#101](#101)) ([074db36](074db36)) * **deps:** update sonarqube support dependencies ([#103](#103)) ([ee1c448](ee1c448)) * **deps:** update sonarqube support dependencies ([#93](#93)) ([47b6bdc](47b6bdc)) * **deps:** update sonarqube support dependencies ([#98](#98)) ([3d342e5](3d342e5)) * remove egress anywhere for SSO ([#102](#102)) ([2c5dd72](2c5dd72)) * update license ([#89](#89)) ([c078724](c078724)) * update to SonarQube 10, migrate to upstream chart, add `unicorn` CGR flavor ([#100](#100)) ([d3ee872](d3ee872)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Racer159
added a commit
that referenced
this pull request
Jul 31, 2024
🤖 I have created a release *beep* *boop* --- ## [10.6.0-uds.0](v9.9.5-uds.1...v10.6.0-uds.0) (2024-07-31) ### ⚠ BREAKING CHANGES * update to SonarQube 10, migrate to upstream chart, add `unicorn` CGR flavor ([#100](#100)) * remove egress anywhere for SSO ([#102](#102)) ### Miscellaneous * add architecture to save logs suffix on tag-and-release ([#92](#92)) ([5fbe70c](5fbe70c)) * **deps:** update sonarqube support dependencies ([#101](#101)) ([074db36](074db36)) * **deps:** update sonarqube support dependencies ([#103](#103)) ([ee1c448](ee1c448)) * **deps:** update sonarqube support dependencies ([#93](#93)) ([47b6bdc](47b6bdc)) * **deps:** update sonarqube support dependencies ([#98](#98)) ([3d342e5](3d342e5)) * fix sonarqube runner to big-boy-4-core ([#106](#106)) ([01d883f](01d883f)) * remove egress anywhere for SSO ([#102](#102)) ([2c5dd72](2c5dd72)) * update license ([#89](#89)) ([c078724](c078724)) * update to SonarQube 10, migrate to upstream chart, add `unicorn` CGR flavor ([#100](#100)) ([d3ee872](d3ee872)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <me@racer159.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds matrix.architecture to the save logs suffix so that files from different workflow runs won't conflict. See https://github.com/defenseunicorns/uds-package-sonarqube/actions/runs/9599733342/job/26474249666 for an example of the error when they collide.
This was introduced with adding the architecture to the workflow matrix and not adding it the the save logs step.
Type of change
Checklist before merging