Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost access to setVariableMap #2472

Closed
decleaver opened this issue May 3, 2024 · 0 comments · Fixed by #2475
Closed

Lost access to setVariableMap #2472

decleaver opened this issue May 3, 2024 · 0 comments · Fixed by #2475
Assignees
@decleaver
Labels
possible-bug 🐛

Comments

@decleaver
Copy link
Contributor

Environment

zarf v0.33.1

Description

Unable to access SetVariableMap outside of zarf packages

In zarf v0.33.0 SetVariableMap is a public field in PackagerConfig

In zarf v0.33.1 the setVariableMap got moved to a field in VariableConfig (the GetSetVariable function was also added so you can still access the setVariableMap even though its a private field of VariableConfig) and variableConfiggot added toPackageras a private field with no getter, making the setVariableMap inaccessible outside of thepackager` package.

Proposed Fix

Add a publicGetVariableConfig() function to allow for external access
@decleaver decleaver self-assigned this May 3, 2024
@decleaver decleaver mentioned this issue May 3, 2024
Merged
2 tasks
AustinAbro321 added a commit that referenced this issue May 6, 2024
@decleaver @AustinAbro321
fix: adds GetVariableConfig function for packager (#2475)
0fa2173 
## Description

Makes Packager's variableConfig publicly accessible which in turns
allows access to VariableConfig's setVariableMap which is currently
being used by uds-cli for bundle deployment processing.

## Related Issue

Fixes #2472

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decleaver decleaver

Labels
possible-bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adds GetVariableConfig function for packager zarf-dev/zarf
1 participant
@decleaver