-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarf (helm) ignores strict schema decoding on deploy #2548
Labels
Comments
5 tasks
After further reviewing the helm behavior this appears to be slightly less bad than originally expected - helm does enforce the schema for required fields/types but does not prohibit/restrict unknown fields from being added. This is different from default |
mjnagel
added a commit
to defenseunicorns/uds-core
that referenced
this issue
May 24, 2024
## Description Fixes the `Package` CRs to have the correct name in the spec. ## Related Issue Note that this was not caught earlier due to zarf-dev/zarf#2548 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed
Updating to link a different upstream helm issue helm/helm#13053 |
rjferguson21
pushed a commit
to defenseunicorns/uds-core
that referenced
this issue
Jul 11, 2024
## Description Fixes the `Package` CRs to have the correct name in the spec. ## Related Issue Note that this was not caught earlier due to zarf-dev/zarf#2548 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Device and OS: macOS
App version: v0.34.0
Kubernetes distro being used: k3d
Steps to reproduce
Reproduction is using a k3s custom resource, so this should be reproducable on a k3d cluster easily.
kubectl apply
the manifest. You will see an error likeError from server (BadRequest): error when creating "addon.yaml": Addon in version "v1" cannot be handled as a Addon: strict decoding error: unknown field "spec.noSchema"
.Expected result
Zarf package would fail to deploy with the same schema error.
Actual Result
Zarf package successfully deploys, resulting in a bad CR in cluster.
Visual Proof (screenshots, videos, text, etc)
Logs
Severity/Priority
This feels relatively important since it could lean to unknown states if operators are not built to handle non-schema adhering custom resources.
Additional Context
It appears that this may be an upstream helm issue, I was able to reproduce the same behavior just with a basic helm chart. See helm/helm#12470 which seems to be tracking this problem. Unsure that it would make sense to do anything on the zarf side to handle this, but wanted to open the issue for tracking/discussion. Unsure if other projects like flux have encountered this issue and handled it or if everything is waiting on helm upstream.
The text was updated successfully, but these errors were encountered: