Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adoption of Namespaces with --adopt-existing-resources #2624

Open
Racer159 opened this issue Jun 13, 2024 · 1 comment
Open

Adoption of Namespaces with --adopt-existing-resources #2624

Racer159 opened this issue Jun 13, 2024 · 1 comment
Labels
enhancement ✨ New feature or request

Comments

@Racer159
Copy link
Contributor

Racer159 commented Jun 13, 2024

Is your feature request related to a problem? Please describe.

As Ezra I want to be able to adopt namespaces with --adopt-existing-resources so that I can get deployments into a consistent state if the namespace already exists.

Describe the solution you'd like

  • Given I have a Zarf package that deploys to a namespace
  • And I do not override namespace labels in the Zarf package (i.e. with a namespace Helm template)
  • And the namespace exists and has a zarf.dev/agent: ignore label
  • When I deploy my package with --adopt-existing-resources
  • Then the zarf.dev/agent: ignore label is dropped

  • Given I have a Zarf package that deploys to a namespace
  • And I have a zarf.dev/agent: ignore label in the Zarf package (i.e. with a namespace Helm template)
  • And the namespace exists and has a zarf.dev/agent: ignore label
  • When I deploy my package with --adopt-existing-resources
  • Then the zarf.dev/agent: ignore label is kept

  • Given I have a Zarf package that deploys to a namespace
  • And I have a zarf.dev/agent: ignore label in the Zarf package (i.e. with a namespace Helm template)
  • And the namespace exists and does not have additional labels
  • When I deploy my package with --adopt-existing-resources
  • Then the zarf.dev/agent: ignore label is added

Describe alternatives you've considered

This could be done with more labels or in a more global way but the zarf.dev/agent: ignore label is the most common Zarf-specific one folks may run into (especially given Zarf adds this label to all namespaces on zarf init).

Additional context

This came out of the resolution of: #2623

Namespace labels should not be mutate when not passing the --adopt-existing-resources flag

@Racer159 Racer159 added the enhancement ✨ New feature or request label Jun 13, 2024
@phillebaba
Copy link
Member

Relates to #2693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants