Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override State Parameters During Init #421

Merged
merged 7 commits into from
Mar 30, 2022
Merged

Override State Parameters During Init #421

merged 7 commits into from
Mar 30, 2022

Conversation

YrrepNoj
Copy link
Contributor

@YrrepNoj YrrepNoj commented Mar 29, 2022 •
edited
Loading

Add flags to override certain Zarf State variables during init.

Closes #421

@YrrepNoj YrrepNoj force-pushed the 393-override-state-parameters branch from f3bd8e9 to a60ee89 Compare March 29, 2022 16:47
@YrrepNoj YrrepNoj force-pushed the 393-override-state-parameters branch from e717570 to 73cfe6f Compare March 29, 2022 18:52
@YrrepNoj YrrepNoj changed the title DRAFT: Override State Parameters Override State Parameters During Init Mar 30, 2022
@YrrepNoj YrrepNoj marked this pull request as ready for review March 30, 2022 02:08
jeff-mccoy
jeff-mccoy requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, as discussed, I think we can just keep these flags only in zarf init since it's a very specific and likely very rare use-case.

jeff-mccoy
jeff-mccoy approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@jeff-mccoy jeff-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@jeff-mccoy jeff-mccoy merged commit b6b7f36 into master Mar 30, 2022
@jeff-mccoy jeff-mccoy deleted the 393-override-state-parameters branch March 30, 2022 04:17
@jeff-mccoy jeff-mccoy mentioned this pull request Apr 7, 2022
Open
@YrrepNoj YrrepNoj mentioned this pull request Apr 20, 2022
Closed
3 tasks
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
@YrrepNoj
Override State Parameters During Init (#421)
4ab2d09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YrrepNoj @jeff-mccoy