Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor required parameters #79

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Refactor required parameters #79

merged 1 commit into from
Jul 31, 2019

Conversation

jlegrone
Copy link
Member

@jlegrone jlegrone commented Jul 24, 2019 •
edited
Loading

Relates to #68

vdice
vdice reviewed Jul 24, 2019
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me! Only one note around changes currently shown. Otherwise, after updating the other unit tests as appropriate, I'd think we're getting close.

bundle/parameters.go Outdated Show resolved Hide resolved
@jcsirot
Copy link
Contributor

jcsirot commented Jul 25, 2019 •
edited
Loading

Since Parameters is now a map of Parameter I think that these checks are not required anymore:
https://github.com/deislabs/cnab-go/blob/22ed003cf91e38449b08dfbf12ba1f5dc0f83344/bundle/bundle.go#L145
https://github.com/deislabs/cnab-go/blob/22ed003cf91e38449b08dfbf12ba1f5dc0f83344/action/action.go#L84

@jlegrone jlegrone force-pushed the feature/parameter-definition-refactor branch from 22ed003 to db7df3a Compare July 26, 2019 20:00
@jlegrone jlegrone marked this pull request as ready for review July 26, 2019 20:09
@jlegrone jlegrone force-pushed the feature/parameter-definition-refactor branch from db7df3a to 010688e Compare July 26, 2019 20:18
radu-matei
radu-matei reviewed Jul 30, 2019
View reviewed changes
bundle/parameters_test.go
"description": "%s",
"applyTo": [ "%s", "%s" ]
}
"test": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a small check for the required property here?

radu-matei
radu-matei reviewed Jul 30, 2019
View reviewed changes
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, everything looks great. Could you please add another test for checking that required is actually set for parameters? Thanks!

I think this PR should probably not close #68 because of cnabio/cnab-spec#233.

vdice
vdice reviewed Jul 31, 2019
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a rebasing and addressing #79 (comment) , I think this should be good to go.

@jlegrone jlegrone force-pushed the feature/parameter-definition-refactor branch from 010688e to 5be9237 Compare July 31, 2019 19:53
radu-matei
radu-matei approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

jeremyrickard
jeremyrickard approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremyrickard jeremyrickard merged commit 44f18fa into cnabio:master Jul 31, 2019
@jlegrone jlegrone deleted the feature/parameter-definition-refactor branch July 31, 2019 20:07
@vdice vdice mentioned this pull request Aug 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice left review comments

@radu-matei radu-matei radu-matei approved these changes

@jeremyrickard jeremyrickard jeremyrickard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlegrone @jcsirot @vdice @radu-matei @jeremyrickard