Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.9.1 #154

Closed
0xE282B0 opened this issue Sep 19, 2023 · 7 comments
Closed

release v0.9.1 #154

0xE282B0 opened this issue Sep 19, 2023 · 7 comments

Comments

@0xE282B0
Copy link
Contributor

Hi all,
Since the v0.9.0 release, cgroups v1 support has been added, making the shims compatible with more kubernetes distributions KWasm/kwasm-node-installer#43.

Could we do a v0.9.1 release where the artifacts can be downloaded from the release page?

@Mossaka
Copy link
Member

Mossaka commented Sep 19, 2023

For sure I will do a release today

@0xE282B0
Copy link
Contributor Author

Thank you!

@Mossaka
Copy link
Member

Mossaka commented Sep 19, 2023

Umm I was doing some smoke tests with the newly released k3d cluster v0.9.1. When I applied the workloads, I got this error

Failed to pull image "ghcr.io/deislabs/containerd-wasm-shims/examples/spin-rust-hello:v0.9.1": 
rpc error: code = NotFound desc = failed to pull and unpack image "ghcr.io/deislabs/containerd-wasm-shims/examples/spin-rust-hello:v0.9.1": 
no match for platform in manifest: not found

@Mossaka Mossaka reopened this Sep 19, 2023
@Mossaka
Copy link
Member

Mossaka commented Sep 19, 2023

It looks like the issue lies in the images that only supportwasi/wasm.

If you change the container spec in workload.yaml to ghcr.io/deislabs/containerd-wasm-shims/examples/spin-rust-hello:v0.9.1@sha256:a1fb089c3452c509044ef82f0c7f81bbdb7b8dca5a8cb36d6268b0324c6fd8e3 for the spin shim, then it should work.

However, this isn't ideal because we don't know the digest value until after they arepublished to a registry.

@mboersma
Copy link

I just noticed your comment, but already opened #159.

Is it possible to restore the linux/amd64 layers? Having only wasi/wasm makes the demos harder to work with (I'm trying to update the shims and documentation in Kubernetes image-builder so we can continue to support Wasm in Cluster API).

Or perhaps we could update the runtime.yaml example to include the sha256 annotations? It's not reasonable for a user to figure these out IMHO.

@Mossaka
Copy link
Member

Mossaka commented Sep 21, 2023

I reverted the docker build action in #160 .

It looked like we get linux/amd64 images https://github.com/deislabs/containerd-wasm-shims/pkgs/container/containerd-wasm-shims%2Fexamples%2Fspin-rust-hello/130079317?tag=v0.9.1

@Mossaka
Copy link
Member

Mossaka commented Sep 21, 2023

v0.9.1 was just released. I did some smoking test and it looked fine!

@Mossaka Mossaka closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants