Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sanitized_text method - Fix #7 #8

Merged
merged 1 commit into from
May 14, 2016
Merged

Replace sanitized_text method - Fix #7 #8

merged 1 commit into from
May 14, 2016

Conversation

bcoles
Copy link
Contributor

@bcoles bcoles commented Apr 23, 2016

Remove sanitized_text method and use IO.popen rather than system to prevent command injection.

@bcoles
Replace sanitized_text method - Fix #7
5251744 
Remove `sanitized_text` method and use `IO.popen` rather than `system` to prevent command injection.
@dejan dejan merged commit 119b2d6 into dejan:master May 14, 2016
@dejan
Copy link
Owner

dejan commented May 14, 2016

Thank you!

@dejan dejan mentioned this pull request May 14, 2016
Merged
@bcoles
Copy link
Contributor Author

bcoles commented Jan 31, 2017

Looks like I left out res.close for each instance of popen which is causing zombie processes, as per #10

@dejan
Copy link
Owner

dejan commented Feb 1, 2017

@bcoles Fixed in #11. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcoles @dejan