You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in dekorate we have almost 18 enums. Those enums are used in the dekorate annotations. In most cases the annotations define the default value and the rest of the code just applies whatever value is found in the config objects. This works fine for dekorate itself but has issues with downstream projects. Why? because a dekorator applying the default or overriden value will always be applied possibly clashing with dekorators registered downstream.
For example, with the given code we always register a dekorator that sets the image pull policy, wether the user selected a non default value or not. This is breaking downstream projects that use their own config model.
What should we do? Only register decorators when non default values are selected.
Note: This issue most probably applies to other types too.
The text was updated successfully, but these errors were encountered:
Currently in dekorate we have almost 18 enums. Those enums are used in the dekorate annotations. In most cases the annotations define the default value and the rest of the code just applies whatever value is found in the config objects. This works fine for dekorate itself but has issues with downstream projects. Why? because a dekorator applying the default or overriden value will always be applied possibly clashing with dekorators registered downstream.
For example, with the given code we always register a dekorator that sets the image pull policy, wether the user selected a non default value or not. This is breaking downstream projects that use their own config model.
What should we do? Only register decorators when non default values are selected.
Note: This issue most probably applies to other types too.
The text was updated successfully, but these errors were encountered: