[WIP] add parameter for chart version, add repository parameter, add helm home #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarby
changed the title
|
Initially this looks very safe to me. Thanks for your contribution 🎉 Do you need to run |
|
no, helm update is not required if you provide a URL it will simply pull from that URL |
colinjfw
approved these changes
Feb 27, 2020
mlwelles
pushed a commit
to noho-digital/helm
that referenced
this pull request
Aug 19, 2020
…ot#23) Adds the following parameters to allow downloading a chart by url: * chart-version * repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be 2 issues in one PR but it seems trivial not to separate them.
Initially this should fix: #21 for @raj-shekhar1 , in getting this to work it was necessary to hardcode the helm home argument in the install command (to where docker will install helm to) i'm not entirely happy with this so am open to comments on a better solution (this is fixed in helm3 i believe but shouldn't hurt)
also we need to specify which chart version should be installed which is different to the application version. So i have added this parameter in what should be a backwards compatible manner