From e888ff1996e3ad32892fd0a5412cc3ff06259faf Mon Sep 17 00:00:00 2001 From: delldubey Date: Mon, 4 Dec 2023 17:12:26 +0530 Subject: [PATCH] updates for gosec (#254) --- csireverseproxy/main.go | 5 +++-- csireverseproxy/pkg/k8smock/k8smock.go | 2 ++ csireverseproxy/pkg/k8sutils/k8sutils.go | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/csireverseproxy/main.go b/csireverseproxy/main.go index 2d40fceb..b4e66822 100644 --- a/csireverseproxy/main.go +++ b/csireverseproxy/main.go @@ -160,8 +160,9 @@ func (s *Server) Start() { port := utils.GetListenAddress(s.Port) handler := s.GetRevProxy().GetRouter() server := http.Server{ - Addr: port, - Handler: handler, + Addr: port, + Handler: handler, + ReadHeaderTimeout: 5 * time.Second, } go func() { defer s.WaitGroup.Done() diff --git a/csireverseproxy/pkg/k8smock/k8smock.go b/csireverseproxy/pkg/k8smock/k8smock.go index cb49d9cf..62252f38 100644 --- a/csireverseproxy/pkg/k8smock/k8smock.go +++ b/csireverseproxy/pkg/k8smock/k8smock.go @@ -18,6 +18,7 @@ import ( "context" "fmt" "os" + "path/filepath" "strconv" "time" @@ -107,6 +108,7 @@ func (mockUtils *MockUtils) GetCertFileFromSecretName(secretName string) (string } func (mockUtils *MockUtils) createFile(fileName string, data []byte) error { + fileName = filepath.Clean(fileName) file, err := os.Create(fileName) if err != nil { return err diff --git a/csireverseproxy/pkg/k8sutils/k8sutils.go b/csireverseproxy/pkg/k8sutils/k8sutils.go index 75b16022..aaac6ae1 100644 --- a/csireverseproxy/pkg/k8sutils/k8sutils.go +++ b/csireverseproxy/pkg/k8sutils/k8sutils.go @@ -209,6 +209,7 @@ func (utils *K8sUtils) GetCredentialsFromSecret(secret *corev1.Secret) (*common. } func (utils *K8sUtils) createFile(fileName string, data []byte) error { + fileName = filepath.Clean(fileName) file, err := os.Create(fileName) if err != nil { return err