From 532216c1818aef744d1227a3f56df210fe187c2a Mon Sep 17 00:00:00 2001 From: Alik Saring Date: Fri, 7 Oct 2022 10:50:30 -0400 Subject: [PATCH 1/6] Ignore volumeless pods with Resiliency label --- content/docs/resiliency/deployment.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/content/docs/resiliency/deployment.md b/content/docs/resiliency/deployment.md index 11cda42513..12da758ff0 100644 --- a/content/docs/resiliency/deployment.md +++ b/content/docs/resiliency/deployment.md @@ -33,6 +33,7 @@ podmon: - "--skipArrayConnectionValidation=false" - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml" - "--driverPodLabelValue=dell-storage" + - "--ignoreVolumelessPods=false" node: args: - "--csisock=unix:/var/lib/kubelet/plugins/vxflexos.emc.dell.com/csi_sock" @@ -41,6 +42,7 @@ podmon: - "--leaderelection=false" - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml" - "--driverPodLabelValue=dell-storage" + - "--ignoreVolumelessPods=false" ``` @@ -65,6 +67,7 @@ To install CSM for Resiliency with the driver, the following changes are require | arrayConnectivityPollRate | Optional | The minimum polling rate in seconds to determine if the array has connectivity to a node. Should not be set to less than 5 seconds. See the specific section for each array type for additional guidance. | controller & node | | arrayConnectivityConnectionLossThreshold | Optional | Gives the number of failed connection polls that will be deemed to indicate array connectivity loss. Should not be set to less than 3. See the specific section for each array type for additional guidance. | controller | | driver-config-params | Required | String that set the path to a file containing configuration parameter(for instance, Log levels) for a driver. | controller & node | +| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore volumeless pods even if those are labeled. | controller & node | ## PowerFlex Specific Recommendations @@ -86,6 +89,7 @@ podmon: - "--skipArrayConnectionValidation=false" - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml" - "--driverPodLabelValue=dell-storage" + - "--ignoreVolumelessPods=false" node: args: - "--csisock=unix:/var/lib/kubelet/plugins/vxflexos.emc.dell.com/csi_sock" @@ -94,6 +98,7 @@ podmon: - "--leaderelection=false" - "--driver-config-params=/vxflexos-config-params/driver-config-params.yaml" - "--driverPodLabelValue=dell-storage" + - "--ignoreVolumelessPods=false" ``` @@ -114,6 +119,7 @@ podmon: - "--skipArrayConnectionValidation=false" - "--driver-config-params=/unity-config/driver-config-params.yaml" - "--driverPodLabelValue=dell-storage" + - "--ignoreVolumelessPods=false" node: args: - "--csisock=unix:/var/lib/kubelet/plugins/unity.emc.dell.com/csi_sock" @@ -123,6 +129,7 @@ podmon: - "--leaderelection=false" - "--driver-config-params=/unity-config/driver-config-params.yaml" - "--driverPodLabelValue=dell-storage" + - "--ignoreVolumelessPods=false" ``` @@ -144,6 +151,7 @@ podmon: - "--skipArrayConnectionValidation=false" - "--driver-config-params=/csi-isilon-config-params/driver-config-params.yaml" - "--driverPodLabelValue=dell-storage" + - "--ignoreVolumelessPods=false" node: args: - "--csisock=unix:/var/lib/kubelet/plugins/csi-isilon/csi_sock" @@ -154,6 +162,7 @@ podmon: - "--leaderelection=false" - "--driver-config-params=/csi-isilon-config-params/driver-config-params.yaml" - "--driverPodLabelValue=dell-storage" + - "--ignoreVolumelessPods=false" ``` ## Dynamic parameters From f3cd2dfc096f3384dae3141141be8717f92c9a46 Mon Sep 17 00:00:00 2001 From: Alik Saring Date: Fri, 7 Oct 2022 11:18:48 -0400 Subject: [PATCH 2/6] pr review edit --- content/docs/resiliency/deployment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/resiliency/deployment.md b/content/docs/resiliency/deployment.md index 12da758ff0..bffef89295 100644 --- a/content/docs/resiliency/deployment.md +++ b/content/docs/resiliency/deployment.md @@ -67,7 +67,7 @@ To install CSM for Resiliency with the driver, the following changes are require | arrayConnectivityPollRate | Optional | The minimum polling rate in seconds to determine if the array has connectivity to a node. Should not be set to less than 5 seconds. See the specific section for each array type for additional guidance. | controller & node | | arrayConnectivityConnectionLossThreshold | Optional | Gives the number of failed connection polls that will be deemed to indicate array connectivity loss. Should not be set to less than 3. See the specific section for each array type for additional guidance. | controller | | driver-config-params | Required | String that set the path to a file containing configuration parameter(for instance, Log levels) for a driver. | controller & node | -| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore volumeless pods even if those are labeled. | controller & node | +| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attach to it even if those pods are labeled. | controller & node | ## PowerFlex Specific Recommendations From 148b78e095144330acbbe788314ebfba5a5c94c2 Mon Sep 17 00:00:00 2001 From: Alik Saring Date: Fri, 7 Oct 2022 13:20:50 -0400 Subject: [PATCH 3/6] pr review edit --- content/docs/resiliency/deployment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/resiliency/deployment.md b/content/docs/resiliency/deployment.md index bffef89295..19dd67e5db 100644 --- a/content/docs/resiliency/deployment.md +++ b/content/docs/resiliency/deployment.md @@ -67,7 +67,7 @@ To install CSM for Resiliency with the driver, the following changes are require | arrayConnectivityPollRate | Optional | The minimum polling rate in seconds to determine if the array has connectivity to a node. Should not be set to less than 5 seconds. See the specific section for each array type for additional guidance. | controller & node | | arrayConnectivityConnectionLossThreshold | Optional | Gives the number of failed connection polls that will be deemed to indicate array connectivity loss. Should not be set to less than 3. See the specific section for each array type for additional guidance. | controller | | driver-config-params | Required | String that set the path to a file containing configuration parameter(for instance, Log levels) for a driver. | controller & node | -| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attach to it even if those pods are labeled. | controller & node | +| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attach to it even if those pods has CSM for Resiliency label on it. | controller & node | ## PowerFlex Specific Recommendations From ad82eae3012d5152a0244b19ae60beb61b6f99d9 Mon Sep 17 00:00:00 2001 From: Alik Saring Date: Fri, 7 Oct 2022 13:39:54 -0400 Subject: [PATCH 4/6] pr review edit --- content/docs/resiliency/deployment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/resiliency/deployment.md b/content/docs/resiliency/deployment.md index 19dd67e5db..bde49b7a4a 100644 --- a/content/docs/resiliency/deployment.md +++ b/content/docs/resiliency/deployment.md @@ -67,7 +67,7 @@ To install CSM for Resiliency with the driver, the following changes are require | arrayConnectivityPollRate | Optional | The minimum polling rate in seconds to determine if the array has connectivity to a node. Should not be set to less than 5 seconds. See the specific section for each array type for additional guidance. | controller & node | | arrayConnectivityConnectionLossThreshold | Optional | Gives the number of failed connection polls that will be deemed to indicate array connectivity loss. Should not be set to less than 3. See the specific section for each array type for additional guidance. | controller | | driver-config-params | Required | String that set the path to a file containing configuration parameter(for instance, Log levels) for a driver. | controller & node | -| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attach to it even if those pods has CSM for Resiliency label on it. | controller & node | +| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attach to the pod | controller & node | ## PowerFlex Specific Recommendations From 9a6bedb30096776ddf760a9a04431499a9623861 Mon Sep 17 00:00:00 2001 From: Alik Saring Date: Fri, 7 Oct 2022 13:41:56 -0400 Subject: [PATCH 5/6] pr review edit --- content/docs/resiliency/deployment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/resiliency/deployment.md b/content/docs/resiliency/deployment.md index bde49b7a4a..17647e0614 100644 --- a/content/docs/resiliency/deployment.md +++ b/content/docs/resiliency/deployment.md @@ -67,7 +67,7 @@ To install CSM for Resiliency with the driver, the following changes are require | arrayConnectivityPollRate | Optional | The minimum polling rate in seconds to determine if the array has connectivity to a node. Should not be set to less than 5 seconds. See the specific section for each array type for additional guidance. | controller & node | | arrayConnectivityConnectionLossThreshold | Optional | Gives the number of failed connection polls that will be deemed to indicate array connectivity loss. Should not be set to less than 3. See the specific section for each array type for additional guidance. | controller | | driver-config-params | Required | String that set the path to a file containing configuration parameter(for instance, Log levels) for a driver. | controller & node | -| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attach to the pod | controller & node | +| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attach to the pod. | controller & node | ## PowerFlex Specific Recommendations From 3412ba532f5468faa896e97f03aa8ebb95102d20 Mon Sep 17 00:00:00 2001 From: Alik Saring Date: Mon, 10 Oct 2022 14:46:06 -0400 Subject: [PATCH 6/6] pr review edit --- content/docs/resiliency/deployment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/resiliency/deployment.md b/content/docs/resiliency/deployment.md index 17647e0614..ec7c5fb61b 100644 --- a/content/docs/resiliency/deployment.md +++ b/content/docs/resiliency/deployment.md @@ -67,7 +67,7 @@ To install CSM for Resiliency with the driver, the following changes are require | arrayConnectivityPollRate | Optional | The minimum polling rate in seconds to determine if the array has connectivity to a node. Should not be set to less than 5 seconds. See the specific section for each array type for additional guidance. | controller & node | | arrayConnectivityConnectionLossThreshold | Optional | Gives the number of failed connection polls that will be deemed to indicate array connectivity loss. Should not be set to less than 3. See the specific section for each array type for additional guidance. | controller | | driver-config-params | Required | String that set the path to a file containing configuration parameter(for instance, Log levels) for a driver. | controller & node | -| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attach to the pod. | controller & node | +| ignoreVolumelessPods | Optional | Boolean value that if set to true will enable CSM for Resiliency to ignore pods without persistent volume attached to the pod. | controller & node | ## PowerFlex Specific Recommendations