[BUG]: Migration failed when there are empty MV SG's on source array

[boyamurthy]

Bug Description

when we are trying to migrate from array A to B , migration is failing if there are empty MV's present on the array A.

Logs

time="2023-03-05T14:49:55Z" level=debug msg="\n -------------------------- POWERMAX HTTP REQUEST -------------------------\n GET /univmax/restapi/100/sloprovisioning/symmetrix/000120001136/storagegroup/csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC HTTP/1.1\n Host: 10.109.123.185:2222\n Accept: application/json;version=100\n Application-Type: CSI Driver for Dell EMC PowerMax/v2.5.0+dirty\n Content-Type: application/json;version=100\n Symid: 000120001136\n \n"
time="2023-03-05T14:49:55Z" level=debug msg="\n -------------------------- POWERMAX HTTP RESPONSE -------------------------\n HTTP/1.1 200 OK\n Transfer-Encoding: chunked\n Content-Security-Policy: default-src 'self'\n Content-Type: application/json\n Date: Sun, 05 Mar 2023 15:14:04 GMT\n Referrer-Policy: no-referrer-when-downgrade\n Restapi-Active-Session-Count: 3\n Restapi-Processing-Time: 61\n Strict-Transport-Security: max-age=31536000; includeSubDomains\n X-Content-Security-Policy: default-src 'self'\n X-Content-Type-Options: nosniff\n X-Frame-Options: SAMEORIGIN\n X-Webkit-Csp: default-src 'self'\n X-Xss-Protection: 1; mode=block\n \n 1c9\n {"storageGroupId":"csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC","slo":"NONE","slo_compliance":"NONE","num_of_vols":1,"num_of_child_sgs":0,"num_of_parent_sgs":0,"num_of_masking_views":1,"num_of_snapshots":0,"cap_gb":8.0,"device_emulation":"FBA","type":"Standalone","unprotected":true,"maskingview":["csi-mv-MIG-worker-2-bdlssidpywklj-FC"],"compression":false,"compression_ratio_to_one":0.0,"uuid":"6000097007271270519e018c00000aba","unreducible_data_gb":0.0}\n 0\n \n"
time="2023-03-05T14:49:55Z" level=debug msg="username: smc , password: *****"
time="2023-03-05T14:49:55Z" level=debug msg="\n -------------------------- POWERMAX HTTP REQUEST -------------------------\n GET /univmax/restapi/100/migration/symmetrix/000120001136/storagegroup/csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC HTTP/1.1\n Host: 10.109.123.185:2222\n Accept: application/json;version=100\n Application-Type: CSI Driver for Dell EMC PowerMax/v2.5.0+dirty\n Content-Type: application/json;version=100\n Symid: 000120001136\n \n"
time="2023-03-05T14:49:55Z" level=debug msg="\n -------------------------- POWERMAX HTTP RESPONSE -------------------------\n HTTP/1.1 404 Not Found\n Transfer-Encoding: chunked\n Content-Security-Policy: default-src 'self'\n Content-Type: application/json\n Date: Sun, 05 Mar 2023 15:14:04 GMT\n Referrer-Policy: no-referrer-when-downgrade\n Restapi-Active-Session-Count: 4\n Restapi-Processing-Time: 23\n Strict-Transport-Security: max-age=31536000; includeSubDomains\n X-Content-Security-Policy: default-src 'self'\n X-Content-Type-Options: nosniff\n X-Frame-Options: SAMEORIGIN\n X-Webkit-Csp: default-src 'self'\n X-Xss-Protection: 1; mode=block\n \n 5d\n {"message":"Storage Group csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC is not in a migration"}\n 0\n \n"
time="2023-03-05T14:49:55Z" level=debug msg="username: smc , password: *****"
time="2023-03-05T14:49:55Z" level=debug msg="\n -------------------------- POWERMAX HTTP REQUEST -------------------------\n POST /univmax/restapi/100/migration/symmetrix/000120001136/storagegroup/csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC HTTP/1.1\n Host: 10.109.123.185:2222\n Accept: application/json;version=100\n Application-Type: CSI Driver for Dell EMC PowerMax/v2.5.0+dirty\n Content-Type: application/json;version=100\n Symid: 000120001136\n \n {"otherArrayId":"000120001178","executionOption":"SYNCHRONOUS"}\n"
time="2023-03-05T14:50:55Z" level=debug msg="\n -------------------------- POWERMAX HTTP RESPONSE -------------------------\n HTTP/1.1 201 Created\n Transfer-Encoding: chunked\n Content-Security-Policy: default-src 'self'\n Content-Type: application/json\n Date: Sun, 05 Mar 2023 15:15:04 GMT\n Location: https://10.228.210.49:8443/univmax/restapi/100/migration/symmetrix/000120001136/storagegroup/csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC\n Referrer-Policy: no-referrer-when-downgrade\n Restapi-Active-Session-Count: 5\n Restapi-Processing-Time: 59643\n Strict-Transport-Security: max-age=31536000; includeSubDomains\n X-Content-Security-Policy: default-src 'self'\n X-Content-Type-Options: nosniff\n X-Frame-Options: SAMEORIGIN\n X-Webkit-Csp: default-src 'self'\n X-Xss-Protection: 1; mode=block\n \n 593\n {"sourceArray":"000120001136","targetArray":"000120001178","storageGroup":"csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC","state":"Migrating","totalCapacity":8.0,"remainingCapacity":0.0,"devicePairs":[

{"srcVolumeName":"0054C","invalidSrc":false,"missingSrc":false,"tgtVolumeName":"001E5","invalidTgt":false,"missingTgt":false}
],"sourceMaskingView":[{"name":"csi-mv-MIG-worker-2-bdlssidpywklj-FC","invalid":false,"childInvalid":false,"missing":false,"initiatorGroup":{"name":"csi-node-MIG-worker-2-bdlssidpywklj-FC","invalid":false,"childInvalid":false,"missing":false,"initiator":[

{"name":"csi-node-MIG-worker-2-bdlssidpywklj-FC","wwn":"10000090fa180566","invalid":false}
]},"portGroup":{"name":"csi-MIG-OR-1C-0-OR-2C-0-PG","invalid":false,"childInvalid":false,"missing":false,"ports":[

{"name":"OR-1C:0","invalid":false}
,{"name":"OR-2C:0","invalid":false}]}}],"targetMaskingView":[{"name":"csi-mv-MIG-worker-2-bdlssidpywklj-FC","invalid":false,"childInvalid":false,"missing":false,"initiatorGroup":{"name":"csi-node-MIG-worker-2-bdlssidpywklj-FC","invalid":false,"childInvalid":false,"missing":false,"initiator":[

{"name":"csi-node-MIG-worker-2-bdlssidpywklj-FC","wwn":"10000090fa180566","invalid":false}
]},"portGroup":{"name":"csi-MIG-OR-1C-0-OR-2C-0-PG","invalid":false,"childInvalid":false,"missing":false,"ports":[

{"name":"OR-1C:0","invalid":false}
,{"name":"OR-2C:0","invalid":false}]}}],"offline":false,"type":"Storage Group"}\n 0\n \n"
time="2023-03-05T14:50:55Z" level=info msg=" Create SG migration successfully done"
time="2023-03-05T14:50:55Z" level=debug msg="Migration session for sg csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC: session: &{000120001136 000120001178 csi-no-srp-sg-MIG-worker-2-bdlssidpywklj-FC Migrating 8 0 [

{0054C false false 001E5 false false}
] [{csi-mv-MIG-worker-2-bdlssidpywklj-FC false false false {csi-node-MIG-worker-2-bdlssidpywklj-FC false false false [

{csi-node-MIG-worker-2-bdlssidpywklj-FC 10000090fa180566 false}]} {csi-MIG-OR-1C-0-OR-2C-0-PG false false false [{OR-1C:0 false} {OR-2C:0 false}]}}] [{csi-mv-MIG-worker-2-bdlssidpywklj-FC false false false {csi-node-MIG-worker-2-bdlssidpywklj-FC false false false [{csi-node-MIG-worker-2-bdlssidpywklj-FC 10000090fa180566 false}
]} {csi-MIG-OR-1C-0-OR-2C-0-PG false false false [

{OR-1C:0 false}
{OR-2C:0 false}]}}] false Storage Group}"
time="2023-03-05T14:50:55Z" level=debug msg="username: smc , password: *****"
time="2023-03-05T14:50:55Z" level=debug msg="\n -------------------------- POWERMAX HTTP REQUEST -------------------------\n GET /univmax/restapi/100/sloprovisioning/symmetrix/000120001178/storagegroup?storageGroupId=%3Clike%3Ecsi-MIG HTTP/1.1\n Host: 10.109.123.185:2222\n Accept: application/json;version=100\n Application-Type: CSI Driver for Dell EMC PowerMax/v2.5.0+dirty\n Content-Type: application/json;version=100\n Symid: 000120001136\n \n"
time="2023-03-05T14:50:55Z" level=debug msg="\n -------------------------- POWERMAX HTTP RESPONSE -------------------------\n HTTP/1.1 200 OK\n Transfer-Encoding: chunked\n Content-Security-Policy: default-src 'self'\n Content-Type: application/json\n Date: Sun, 05 Mar 2023 15:15:04 GMT\n Referrer-Policy: no-referrer-when-downgrade\n Restapi-Active-Session-Count: 5\n Restapi-Processing-Time: 5\n Strict-Transport-Security: max-age=31536000; includeSubDomains\n X-Content-Security-Policy: default-src 'self'\n X-Content-Type-Options: nosniff\n X-Frame-Options: SAMEORIGIN\n X-Webkit-Csp: default-src 'self'\n X-Xss-Protection: 1; mode=block\n \n 2c\n {"storageGroupId":["csi-MIG-Gold-SRP_1-SG"]}\n 0\n \n"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x11ef039]

goroutine 4148 [running]:
github.com/dell/csi-powermax/v2/pkg/migration.StorageGroupMigration({0x1f04610, 0xc00021b1d0}, {0xc000e4e400, 0xc}, {0xc000e4e410, 0xc}, {0xc000042059, 0x3}, {0x1f1a538, 0xc000221c20})
/go/src/csi-powermax/pkg/migration/migration.go:155 +0xa19
github.com/dell/csi-powermax/v2/service.(*service).ArrayMigrate(0xc0001202c0, {0x1f04610, 0xc00021b1d0}, 0xc000af09c0)
/go/src/csi-powermax/service/migration.go:369 +0xdc5
github.com/dell/dell-csi-extensions/migration._Migration_ArrayMigrate_Handler.func1({0x1f04610, 0xc00021b1d0}, {0x1afec40?, 0xc000af09c0})
/go/pkg/mod/github.com/dell/dell-csi-extensions/migration@v1.0.2-0.20230223220121-65f0c737bc34/migration_grpc.pb.go:167 +0x78

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

Create few MV SG's on source array
try to do migration from A to B

Expected Behavior

Migration should be successful .

CSM Driver(s)

CSI driver for powermax.

Installation Type

No response

Container Storage Modules Enabled

No response

Container Orchestrator

K8's

Operating System

all

[csmbot]

@boyamurthy: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and assign an appropriate priority label.

---

We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.