Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the right name everywhere for array element types and map key/values types #202

Open
nicklan opened this issue May 10, 2024 · 0 comments
Open

Get the right name everywhere for array element types and map key/values types #202

nicklan opened this issue May 10, 2024 · 0 comments

Comments

@nicklan
Copy link
Collaborator

nicklan commented May 10, 2024

  • In schema.rs we use element_type, key_type, and value_type
  • In ffi/lib.rs we use array_element, map_key, and map_value

For the ffi I was going of that names that seemed most common when I searched for parquet naming (don't have all the links at the moment).

We should figure out what is most common/expected/required, and switch to that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicklan