Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand context available for expression evaluation #291

Open
hntd187 opened this issue Jul 22, 2024 · 0 comments
Open

Expand context available for expression evaluation #291

hntd187 opened this issue Jul 22, 2024 · 0 comments

Comments

@hntd187
Copy link
Collaborator

hntd187 commented Jul 22, 2024

For #270 I came to realize a lot of the context we need to do some more elaborate or intelligent expression parsing would require us to expand the context available to expression evaluation.

What @scovich mentioned here #270 (comment) we have a lot of matching of various pairs of expressions, but converting scalars to more literal numeric values has several problems with conversion without knowing types up front. I think the current kind of expression evaluation is inefficient but works in it's current state, I think there is discussion to be had regarding how we might augment this to work with EngineData and rework ArrayData to more efficiently handle some of these cases where blowing out an expression to be copied to ever row is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant