Make deletion vector manipulation less error-prone #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 76.54% 76.56% +0.02%
==========================================
Files 47 47
Lines 9384 9393 +9
Branches 9384 9393 +9
==========================================
+ Hits 7183 7192 +9
Misses 1799 1799
Partials 402 402 ☔ View full report in Codecov by Sentry. |
zachschuermann
approved these changes
Oct 7, 2024
| /// Extends the underlying mask to match the row count of the accompanying data. | ||
| pub fn full_mask(&self) -> Option<Vec<bool>> { | ||
| let mut mask = self.raw_mask.clone()?; | ||
| mask.resize(self.raw_data.as_ref().ok()?.length(), true); |
There was a problem hiding this comment.
very nice! I like this better than extend(iter::repeat().take())
|
flagged as breaking since we are taking the mask private |
nicklan
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletion vectors in a scan result can be truncated, with fewer entries than the corresponding engine data.
Remove a footgun by making the raw DV in a
ScanResultprivate, with new accessors to make it less error-prone to use.