From 3e6a4d61923602d189f559636b3e3e3f61b6a924 Mon Sep 17 00:00:00 2001 From: Cole Mackenzie Date: Thu, 7 Mar 2024 08:46:53 -0800 Subject: [PATCH] fix(#2256): use consistent units of time (#2260) # Description Update timing fields using the suffix `_ms` to be in milliseconds. Doing a quick grep through the repo I only found a few instances of this in the delete.rs file. # Related Issue(s) Closes #2256 # Documentation --- crates/core/src/operations/delete.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/core/src/operations/delete.rs b/crates/core/src/operations/delete.rs index 1ab55310ea..072f4cd875 100644 --- a/crates/core/src/operations/delete.rs +++ b/crates/core/src/operations/delete.rs @@ -201,7 +201,7 @@ async fn execute( let scan_start = Instant::now(); let candidates = find_files(snapshot, log_store.clone(), &state, predicate.clone()).await?; - metrics.scan_time_ms = Instant::now().duration_since(scan_start).as_micros(); + metrics.scan_time_ms = Instant::now().duration_since(scan_start).as_millis(); let predicate = predicate.unwrap_or(Expr::Literal(ScalarValue::Boolean(Some(true)))); @@ -249,7 +249,7 @@ async fn execute( })) } - metrics.execution_time_ms = Instant::now().duration_since(exec_start).as_micros(); + metrics.execution_time_ms = Instant::now().duration_since(exec_start).as_millis(); let mut app_metadata = match app_metadata { Some(meta) => meta,