Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property setting in create is not handled correctly #2247

Closed
ion-elgreco opened this issue Mar 5, 2024 · 0 comments · Fixed by #2264
Closed

Property setting in create is not handled correctly #2247

ion-elgreco opened this issue Mar 5, 2024 · 0 comments · Fixed by #2264
Assignees
Labels
binding/rust Issues for the Rust crate bug Something isn't working

Comments

@ion-elgreco
Copy link
Collaborator

Environment

Currently our property (table configuration) setting during the create action is handled incorrectly. There are some cases where we need to do additional actions such as bumping the protocol version, which we aren't doing. @rtyler @roeap

Examples:

  • Settting "delta.minWriterVersion = '5'" should bump writer protocol to version 5 during the commit with protocol action.
  • Setting "delta.enableChangeDataFeed = true" should bump it to the minim required protocol version to read and write CDF.

There are a couple more cases, my plan is to address this while working on the SET TBLPROPERTIES since the behavior of this should be common.
The common part will be current protocol + TableConfig -> Protocol + Metadata Action. The current protocol will be defined after things like knowing if table contains TimestampNtz, or if operation is calling SET TBLPROPERTIES grabbing the latest protocol of the existing table.

@ion-elgreco ion-elgreco added the bug Something isn't working label Mar 5, 2024
@ion-elgreco ion-elgreco self-assigned this Mar 6, 2024
@rtyler rtyler added the binding/rust Issues for the Rust crate label Mar 7, 2024
@rtyler rtyler closed this as completed in 507c3a3 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants